Uh oh!
There was an error while loading. Please reload this page.
Refactoring and cleanup in connection-related code - #149
Merged
Conversation
…lAuthentication Signed-off-by: Levko Kravets <levko.ne@gmail.com>
… code Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levkoforce-pushed
the
connection-cleanup
branch
from
June 13, 2023 12:29
4a6ed2e to
aad6987Comparekravets-levko
marked this pull request as ready for review
June 13, 2023 12:32
kravets-levko
requested review from
andrefurlan-db, arikfr, nithinkdb, superdupershant, susodapop and yunbodeng-db
as code ownersJune 13, 2023 12:32
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
nithinkdb pushed a commit
to nithinkdb/databricks-sql-nodejs
that referenced
this pull request
Aug 21, 2023
* Cleanup DBSQLClient code; remove redundant and no longer needed NoSaslAuthentication Signed-off-by: Levko Kravets <levko.ne@gmail.com> * Make HttpTransport and related types more type-safe, remove redundant code Signed-off-by: Levko Kravets <levko.ne@gmail.com> * Remove some leftover code Signed-off-by: Levko Kravets <levko.ne@gmail.com> * Update tests Signed-off-by: Levko Kravets <levko.ne@gmail.com> * Pass User-Agent through HttpConnection instead of auth provider Signed-off-by: Levko Kravets <levko.ne@gmail.com> --------- Signed-off-by: Levko Kravets <levko.ne@gmail.com> Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes some things that popped out while I worked on #147. To keep original PR clean, I decided to extract those changes here:
HttpTransportmore type-safe (since we use Thrift only over HTTP, we don't needHttpTransportto be so generic), fix classes that usedITransport/HttpTransportPlainHttpAuthenticationupdate headers instead of completely replaceUser-Agentheader through connection object - previously we did it through auth provider becausePlainHttpAuthenticationwas replacing headers and headers provided byHttpConnectionwere just ignoredMay be easier to review commit by commit