Skip to content

[PECO-930] Add parameterized query support. - #162

Merged
nithinkdb merged 11 commits into
databricks:mainfrom
nithinkdb:PECO-930
Sep 6, 2023
Merged

[PECO-930] Add parameterized query support.#162
nithinkdb merged 11 commits into
databricks:mainfrom
nithinkdb:PECO-930

Conversation

@nithinkdb

@nithinkdbnithinkdb commented Aug 17, 2023•
edited by kravets-levko
Loading

Copy link
Copy Markdown
Contributor

Closes#96

kravets-levko
kravets-levko reviewed Aug 21, 2023
View reviewed changes
Comment threadlib/DBSQLClient.ts
Comment threadlib/utils/ParameterConverter.ts Outdated
Comment threadlib/contracts/IDBSQLSession.ts Outdated
kravets-levko
kravets-levko reviewed Aug 22, 2023
View reviewed changes
Comment threadlib/contracts/IDBSQLSession.ts Outdated
kravets-levko
kravets-levko reviewed Aug 22, 2023
View reviewed changes
Comment threadlib/connection/connections/HttpConnection.ts Outdated
kravets-levko
kravets-levko reviewed Aug 22, 2023
View reviewed changes
Comment threadtests/e2e/parameterized_query.test.js Outdated
kravets-levko
kravets-levko reviewed Aug 22, 2023
View reviewed changes
Comment threadtests/e2e/parameterized_query.test.js Outdated
andrefurlan-db
andrefurlan-db reviewed Aug 26, 2023
View reviewed changes

@andrefurlan-dbandrefurlan-db left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please make sure that we keep it consistent with Go and Python. @rcypher-databricks needs to review this as well

rcypher-databricks
rcypher-databricks reviewed Aug 30, 2023
View reviewed changes

@rcypher-databricksrcypher-databricks left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we discussed I think we need to provide a mechanism where the user can specify the desired sql type.

Comment threadlib/utils/convertToSparkParameters.ts Outdated
@kravets-levko
Revert irrelevant changes
7d90fb4
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko
Refactoring + improve tests
6b28a0d
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
nithinkdband others added 3 commits September 5, 2023 16:50
@nithinkdb
Removed void pointers
ea8e415
@kravets-levko
Remove leftovers from removing VOID
4d6de9d
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko
Add Date/Time parameters support
a426928
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@kravets-levko
Support primitive values as named parameters
9d2fbe6
Signed-off-by: Levko Kravets <levko.ne@gmail.com>
@nithinkdb
nithinkdb merged commit ad10743 into databricks:mainSep 6, 2023
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@andrefurlan-dbandrefurlan-dbandrefurlan-db left review comments
@arikfrarikfrAwaiting requested review from arikfr
@superdupershantsuperdupershantAwaiting requested review from superdupershant
@yunbodeng-dbyunbodeng-dbAwaiting requested review from yunbodeng-db
@susodapopsusodapopAwaiting requested review from susodapop
+2 more reviewers
@kravets-levkokravets-levkokravets-levko approved these changes
@rcypher-databricksrcypher-databricksrcypher-databricks approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Parameterized queries

4 participants

@nithinkdb@kravets-levko@andrefurlan-db@rcypher-databricks