Uh oh!
There was an error while loading. Please reload this page.
Patch thrift package so it handles transport errors with a corresponding opertion's callback - #99
Merged
Merged
Conversation
…nding opertion's callback Signed-off-by: Levko Kravets <levko.ne@gmail.com>
This comment was marked as resolved.
This comment was marked as resolved.
kravets-levko
marked this pull request as ready for review
December 20, 2022 13:09
kravets-levko
requested review from
arikfr, moderakh, superdupershant, susodapop and yunbodeng-db
as code ownersDecember 20, 2022 13:09
…sociated with operation Signed-off-by: Levko Kravets <levko.ne@gmail.com>
kravets-levkoforce-pushed
the
fix-error-handling
branch
from
December 20, 2022 13:23
63733ac to
be3b9c2Compare| } | ||
| responseCallback.call(this.connection, response); | ||
| responseCallback.call(this.connection, response, ...rest); |
Contributor
There was a problem hiding this comment.
Any size limitations on this? I assume this will never cause stack overflow due to ... right?
ContributorAuthor
There was a problem hiding this comment.
Yes, it's 100% safe
nithinkdb
approved these changes
Dec 20, 2022
nithinkdb added a commit
to nithinkdb/databricks-sql-nodejs
that referenced
this pull request
Jan 6, 2023
…nding opertion's callback (databricks#99) * Patch `thrift` package so it handles transport errors with a corresponding opertion's callback Signed-off-by: Levko Kravets <levko.ne@gmail.com> * Export Thrift error types; do not emit error event if error can be associated with operation Signed-off-by: Levko Kravets <levko.ne@gmail.com> Signed-off-by: Levko Kravets <levko.ne@gmail.com> Co-authored-by: Nithin Krishnamurthi <110488533+nithinkdb@users.noreply.github.com> Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com>
fjakobs
commented
Jan 25, 2023
Contributor
Thanks for releasing this. Makes my code a lot simpler. |
kravets-levko
commented
Jan 25, 2023
ContributorAuthor
Hi @fjakobs! Sadly, we've noticed some issues with this patch, but we're working on fixing it. More updates will be ASAP. Also, we're going to release library more often to faster deliver changes to users |
kravets-levko added a commit
that referenced
this pull request
Mar 21, 2023
* Patch `thrift` package so it handles transport errors with a corresponding opertion's callback (#99) * Patch `thrift` package so it handles transport errors with a corresponding opertion's callback Signed-off-by: Levko Kravets <levko.ne@gmail.com> * Export Thrift error types; do not emit error event if error can be associated with operation Signed-off-by: Levko Kravets <levko.ne@gmail.com> Signed-off-by: Levko Kravets <levko.ne@gmail.com> Co-authored-by: Nithin Krishnamurthi <110488533+nithinkdb@users.noreply.github.com> Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com> * Temp Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com> * Initial commit Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com> * Added retry helper Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com> * Changed error handler Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com> * Fixed linting Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com> * Fixed mocharc Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com> * Evaded ts rule Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com> * Added lint ignore Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com> * Removed legacy comment Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com> --------- Signed-off-by: Levko Kravets <levko.ne@gmail.com> Signed-off-by: nithinkdb <nithin.krishnamurthi@databricks.com> Co-authored-by: Levko Kravets <levko.ne@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Nodejs
thriftpackage is build in a way that only errors returned in Thrift RPC response message will be passed to an operation's callback. All other errors, e.g. failed request, non-2xx HTTP response, etc. will be just emitted on connection object.This PR adds a local patch for a
thriftpackage which allows to pass HTTP errors to operation callback which later could be handled in.catch()handlers. It becomes possible to examine error object and find out why particular operation failed. It could be useful, for example, for re-trying particular request if it failed due to HTTP 5xx error, etc.