Uh oh!
There was an error while loading. Please reload this page.
Relax panda and alembic requirements - #116
Closed
bkyryliuk wants to merge 1 commit into
Closed
Conversation
bkyryliuk
requested review from
andrefurlan-db, arikfr, susodapop and yunbodeng-db
as code ownersMay 3, 2023 16:19
susodapop
commented
May 3, 2023
Contributor
Good idea. I'm working on this exact change locally, actually. Just running our e2e tests before pushing my own branch. This PR won't quite work because you haven't included the DCO in your commit (see CONTRIBUTING.md for details). |
bkyryliuk
commented
May 3, 2023
ContributorAuthor
that's great. TY! Will check on DCO |
Signed-off-by: Bogdan Kyryliuk <b.kyryliuk@gmail.com>
susodapop
approved these changes
May 9, 2023
susodapop
commented
May 9, 2023
Contributor
I've mirrored this change in #119 so I can verify it builds. This change will be part of v2.5.2 releasing shortly. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pandas 1.3+ has a regression: pandas-dev/pandas#42549
This PR proposes relaxing alembic and panda requirements