Skip to content

Remove a mypy error message workaround that is unnecessary in mypy 1.15.0 - #484

Draft
wyattscarpenter wants to merge 7 commits into
databricks:mainfrom
wyattscarpenter:patch-1
Draft

Remove a mypy error message workaround that is unnecessary in mypy 1.15.0#484
wyattscarpenter wants to merge 7 commits into
databricks:mainfrom
wyattscarpenter:patch-1

Conversation

@wyattscarpenter

@wyattscarpenterwyattscarpenter commented Jan 2, 2025

Copy link
Copy Markdown
Contributor

TLDR: upgrades mypy to 1.15.0 to remove a workaround for a bug of its, and drops python 3.8 support (since that version of mypy drops it)

This removes a workaround for the problem addressed by "Fix --install-types masking failure details (wyattscarpenter, PR 17485)" mentioned in https://mypy.readthedocs.io/en/stable/changelog.html , which I had previously added a workaround for in the course of contributing a prior PR. (It's fine if the workaround remains in; it doesn't break anything (I think) — although future maintainers may find it a bit confusing!)

This PR drops python 3.8 support, because the fixed version of mypy drops 3.8 support, and so is only useful after this project drops 3.8 support. (Which seems to not be the case yet, as of 2025-05-08, judging by the python-version in https://github.com/databricks/databricks-sql-python/blob/main/pyproject.toml.)

I also ran poetry lock to update the lock file, which was needed.

I also fixed a newly-discovered type error.

Appendix A: verbiage from when this was a draft PR This pr should be good to go next time there's another release of mypy. I'm just keeping it a draft til then.

(I also think I will have to run poetry lock, based on the ci. But I'lll put that off until mypy 1.15.0 is even real.)

The DCO check is currently broken, but now fixed again and I have signed-off all of my commits here 🙇

See python/mypy#17485 or python/mypy#10768 for more information on the problem and one-net-line workaround that used to be here.

Appendix B: superseded changes from an earlier version of this PR While I was here, I also changed something to "poetry.group.dev.dependencies", as the poetry deprecation message suggested, which didn't seem to change anything.

Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
see python/mypy#17485 or python/mypy#10768 for more information
Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
…python 3.8 is eol'd
Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
@wyattscarpenterwyattscarpenter changed the title Remove a mypy error message workaround that should be unnecessary in mypy 1.15.0Remove a mypy error message workaround that is unnecessary in mypy 1.15.0Mar 22, 2026
Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
Comment threadpyproject.toml Outdated
cf https://discuss.python.org/t/requires-python-upper-limits/12663
Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
Signed-off-by: wyattscarpenter <wyattscarpenter@gmail.com>
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant

@wyattscarpenter