Skip to content

E2E POC for python telemetry for connect logs - #581

Merged
saishreeeee merged 269 commits into
telemetryfrom
PECOBLR-457
Jun 10, 2025
Merged

E2E POC for python telemetry for connect logs#581
saishreeeee merged 269 commits into
telemetryfrom
PECOBLR-457

Conversation

@saishreeeee

@saishreeeeesaishreeeee commented Jun 3, 2025•
edited
Loading

Copy link
Copy Markdown
Contributor

What type of PR is this?

  • Refactor
  • Feature
  • Bug Fix
  • Other

Description

Added TelemetryClient and TelemetryClientFactory
Added functionality to export initial telemetry logs

How is this tested?

  • Unit tests
    Added unit tests to check the functionality of telemetry client and telemetry client factory
  • E2E Tests
  • Manually
    Ran a query that triggered the export of initital telemetry log, verified that the log was present in the target table
  • N/A

Related Tickets & Documents

PECOBLR-457

@saishreeeee
saishreeeee marked this pull request as draft June 3, 2025 02:51
@saishreeeee
saishreeeee marked this pull request as ready for review June 3, 2025 05:05
@saishreeeeesaishreeeee self-assigned this Jun 3, 2025
vikrantpuppala
vikrantpuppala reviewed Jun 3, 2025
View reviewed changes

@vikrantpuppalavikrantpuppala left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we break down this PR further please? let's start with simple connect logs, then error logs and then latency logs

Comment threadsrc/databricks/sql/client.py Outdated
Comment threadsrc/databricks/sql/client.py Outdated
Comment threadsrc/databricks/sql/client.py Outdated
Comment threadsrc/databricks/sql/client.py Outdated
Comment threadsrc/databricks/sql/client.py Outdated
Comment threadsrc/databricks/sql/client.py Outdated
Comment threadsrc/databricks/sql/exc.py Outdated
@saishreeeeesaishreeeee changed the title E2E POC for python telemetry for connect + latency + error logsE2E POC for python telemetry for connect logsJun 3, 2025
vikrantpuppala
vikrantpuppala reviewed Jun 3, 2025
View reviewed changes
Comment threadsrc/databricks/sql/client.py Outdated
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
@github-actions

github-actionsBot commented Jun 4, 2025

Copy link
Copy Markdown

Thanks for your contribution! To satisfy the DCO policy in our contributing guide every commit message must include a sign-off message. One or more of your commits is missing this message. You can reword previous commit messages with an interactive rebase (git rebase -i main).

@saishreeeee
added log statements
5f8dff5
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
changed TelemetryClientFactory to a static class and made changes in …
906c187
…unit tests accordingly
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
added lock in TelemetryClientFactory and specified dict type in _client
f6bd9ad
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
changed type of attribute _executor in TelemetryClientFactory
c47bc73
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
removed discovery_url
4a2386b
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
vikrantpuppala
vikrantpuppala reviewed Jun 9, 2025
View reviewed changes
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
Comment threadsrc/databricks/sql/telemetry/models/event.py Outdated
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py
@saishreeeee
removed unused params from driver connection params, initialize_telem…
e4c05d1
…etry_client does not return a telemetry client
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
renamed other as client_cert in auth_mech
bf92c6c
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
jprakash-db
jprakash-db reviewed Jun 9, 2025
View reviewed changes
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
Comment threadsrc/databricks/sql/telemetry/telemetry_client.py Outdated
Comment threadtests/unit/test_telemetry.py
Comment threadtests/unit/test_telemetry.py Outdated
Comment threadtests/unit/test_telemetry.py
Comment threadtests/unit/test_telemetry.py Outdated
@saishreeeee
lazy logging, renamed private variables, defined telemetry endpoints …
e218ef9
…as constants, added callback function while submitting request to executor, changed del to pop
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
changed unittest to pytest
9615519
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
shifted EnumEncoder to telemetry/utils.py
c084846
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
@saishreeeee
changed type of _clients in TelemetryClientFactory
7394295
Signed-off-by: Sai Shree Pradhan <saishree.pradhan@databricks.com>
jprakash-db
jprakash-db approved these changes Jun 10, 2025
View reviewed changes

@jprakash-dbjprakash-db left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for making the changes.

@saishreeeee
saishreeeee merged commit 9dc7d52 into telemetryJun 10, 2025
@saishreeeee
saishreeeee deleted the PECOBLR-457 branch August 1, 2025 08:10
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code reviewCopilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
@jprakash-dbjprakash-dbjprakash-db approved these changes
@deeksha-dbdeeksha-dbAwaiting requested review from deeksha-db
@samikshya-dbsamikshya-dbAwaiting requested review from samikshya-db
@jackyhu-dbjackyhu-dbAwaiting requested review from jackyhu-db
@madhav-dbmadhav-dbAwaiting requested review from madhav-db
@gopalldbgopalldbAwaiting requested review from gopalldb
@jayantsing-dbjayantsing-dbAwaiting requested review from jayantsing-db
@shivam2680shivam2680Awaiting requested review from shivam2680
@vikrantpuppalavikrantpuppalaAwaiting requested review from vikrantpuppala

Assignees

@saishreeeeesaishreeeee

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

20 participants

@saishreeeee@vikrantpuppala@jprakash-db@moderakh@mohitsingla-db@jackyhu-db@lu-wang-dl@shea-parkes@yunbodeng-db@andrefurlan-db@mattdeekay@sebbegg@itsdani@bkyryliuk@WilliamGentry@dbarrundia-tiger@jacobus-herman@nithinkdb@unj1m