Skip to content
This repository was archived by the owner on Jun 19, 2026. It is now read-only.

Incorrectly checking ignoreLeadingWhiteSpace twice - #417

Open
omervk wants to merge 1 commit into
databricks:masterfrom
omervk:patch-1
Open

Incorrectly checking ignoreLeadingWhiteSpace twice#417
omervk wants to merge 1 commit into
databricks:masterfrom
omervk:patch-1

Conversation

@omervk

Copy link
Copy Markdown

No description provided.

}

if ((ignoreLeadingWhiteSpace || ignoreLeadingWhiteSpace) && ParserLibs.isCommonsLib(parserLib)) {
if ((ignoreLeadingWhiteSpace || ignoreTrailingWhiteSpace) && ParserLibs.isCommonsLib(parserLib)) {

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Up to my knowledge, this option is not documented and does not work. I proposed the change in #306 but it was ported into Spark 2.x. So, I decided to close.

@codecov-io

codecov-io commented Mar 16, 2017

Copy link
Copy Markdown

Codecov Report

Merging #417 into master will not change coverage.
The diff coverage is 100%.

@@ Coverage Diff @@
## master #417 +/- ##
=======================================
Coverage 87.01% 87.01% =======================================
Files 12 12 Lines 562 562 Branches 136 136 =======================================
Hits 489 489 Misses 73 73
Impacted FilesCoverage Δ
...n/scala/com/databricks/spark/csv/CsvRelation.scala88.95% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7997c3c...39f4504. Read the comment docs.

Sign up for freeto subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants

@omervk@codecov-io@HyukjinKwon