Able to use project components as golang library - #718
Merged
Conversation
yxxhero
commented
Jan 15, 2025
Collaborator
yxxhero
commented
Jan 15, 2025
Collaborator
dmvolod
commented
Jan 24, 2025
ContributorAuthor
Hi @yxxhero |
yxxhero
commented
Jan 27, 2025
Collaborator
@mumoshu@databus23 WDYT? thanks so much. |
yxxhero
commented
Feb 3, 2025
Collaborator
LGTM |
yxxhero
commented
Feb 3, 2025
Collaborator
@dmvolod all is good. could you squash your commits and signoff your commits? then I will merge this PR. |
dmvolod
commented
Feb 3, 2025
ContributorAuthor
yxxhero
commented
Feb 3, 2025
Collaborator
please signoff your commit |
Signed-off-by: Dmitry Volodin <dmvolod@gmail.com>
dmvolod
commented
Feb 3, 2025
ContributorAuthor
Done. |
abhijith-darshan
commented
Feb 4, 2025
When will this be part of the next release? |
yxxhero
commented
Feb 4, 2025
Collaborator
@abhijith-darshan today. |
yxxhero
commented
Feb 4, 2025
Collaborator
yxxhero
commented
Feb 4, 2025
Collaborator
@abhijith-darshan released. and need feedbacks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves manifests generate related code from the
cmdpackage to themanifestand make Generate manifests function public.fixes#717