feat:support --dependency-update before upgrade by kamilswiec · Pull Request #774 · databus23/helm-diff

kamilswiec · 2025-04-28T19:51:25Z

When using helm diff upgrade command when chart dependencies in charts are absent you have to add run helm dep up chart.

I want to be able to pass most of the arguments that I also use in helm upgrade command. This allows me to reduce duplication and ensure helm diff upgrade uses the same flags as helm upgrade be passing the same ${args} variable.

Tested with helm version 3.17.1.

Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero · 2025-04-28T22:57:26Z

@kamilswiec could you add some unit tests for this?

yxxhero · 2025-05-08T23:41:47Z

@kamilswiec hi. I will merge this if you can add some tests for this feature. and releae new version.

yxxhero · 2025-05-22T10:22:27Z

@kamilswiec ping.

Copilot

Pull Request Overview

This PR adds support for the --dependency-update flag to the helm diff upgrade command, allowing automatic dependency updates before diffing. This eliminates the need to manually run helm dep up chart when chart dependencies are missing and ensures consistency with helm upgrade command arguments.

Added --dependency-update boolean flag to the diff command
Implemented dependency update execution before running the diff operation
Added helper function to execute helm dependency update command

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
cmd/upgrade.go	Added dependencyUpdate flag field, command line flag registration, and logic to execute dependency update before diffing
cmd/helm3.go	Added updateDependencies helper function to execute helm dependency update command

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-15T03:05:42Z

+ return err
+ } else {
+ fmt.Println(string(output))
+ }


[nitpick] The 'else' clause is unnecessary here since the 'if' block returns early on error. Consider removing the 'else' and unindenting the output printing code for better readability.
Suggested change
}
}
fmt.Println(string(output))

Copilot · 2025-08-15T03:05:42Z

+ if err != nil {
+ return err
+ } else {
+ fmt.Println(string(output))


[nitpick] The dependency update output is printed to stdout without any context or formatting. Consider adding a prefix like 'Dependency update:' or using a logger to maintain consistency with other command output formatting in the codebase.
Suggested change
fmt.Println(string(output))
log.Printf("Dependency update: %s", string(output))

yxxhero · 2026-04-26T10:03:39Z

@copilot resolve the merge conflicts in this pull request

kamilswiec · 2025-04-28T19:51:25Z

When using helm diff upgrade command when chart dependencies in charts are absent you have to add run helm dep up chart.

I want to be able to pass most of the arguments that I also use in helm upgrade command. This allows me to reduce duplication and ensure helm diff upgrade uses the same flags as helm upgrade be passing the same ${args} variable.

Tested with helm version 3.17.1.

Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero · 2025-04-28T22:57:26Z

@kamilswiec could you add some unit tests for this?

yxxhero · 2025-05-08T23:41:47Z

@kamilswiec hi. I will merge this if you can add some tests for this feature. and releae new version.

yxxhero · 2025-05-22T10:22:27Z

@kamilswiec ping.

Copilot

Pull Request Overview

This PR adds support for the --dependency-update flag to the helm diff upgrade command, allowing automatic dependency updates before diffing. This eliminates the need to manually run helm dep up chart when chart dependencies are missing and ensures consistency with helm upgrade command arguments.

Added --dependency-update boolean flag to the diff command
Implemented dependency update execution before running the diff operation
Added helper function to execute helm dependency update command

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
cmd/upgrade.go	Added dependencyUpdate flag field, command line flag registration, and logic to execute dependency update before diffing
cmd/helm3.go	Added updateDependencies helper function to execute helm dependency update command

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-15T03:05:42Z

+ return err
+ } else {
+ fmt.Println(string(output))
+ }


[nitpick] The 'else' clause is unnecessary here since the 'if' block returns early on error. Consider removing the 'else' and unindenting the output printing code for better readability.
Suggested change
}
}
fmt.Println(string(output))

Copilot · 2025-08-15T03:05:42Z

+ if err != nil {
+ return err
+ } else {
+ fmt.Println(string(output))


[nitpick] The dependency update output is printed to stdout without any context or formatting. Consider adding a prefix like 'Dependency update:' or using a logger to maintain consistency with other command output formatting in the codebase.
Suggested change
fmt.Println(string(output))
log.Printf("Dependency update: %s", string(output))

yxxhero · 2026-04-26T10:03:39Z

@copilot resolve the merge conflicts in this pull request

kamilswiec · 2025-04-28T19:51:25Z

When using helm diff upgrade command when chart dependencies in charts are absent you have to add run helm dep up chart.

I want to be able to pass most of the arguments that I also use in helm upgrade command. This allows me to reduce duplication and ensure helm diff upgrade uses the same flags as helm upgrade be passing the same ${args} variable.

Tested with helm version 3.17.1.

Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero · 2025-04-28T22:57:26Z

@kamilswiec could you add some unit tests for this?

yxxhero · 2025-05-08T23:41:47Z

@kamilswiec hi. I will merge this if you can add some tests for this feature. and releae new version.

yxxhero · 2025-05-22T10:22:27Z

@kamilswiec ping.

Copilot

Pull Request Overview

This PR adds support for the --dependency-update flag to the helm diff upgrade command, allowing automatic dependency updates before diffing. This eliminates the need to manually run helm dep up chart when chart dependencies are missing and ensures consistency with helm upgrade command arguments.

Added --dependency-update boolean flag to the diff command
Implemented dependency update execution before running the diff operation
Added helper function to execute helm dependency update command

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
cmd/upgrade.go	Added dependencyUpdate flag field, command line flag registration, and logic to execute dependency update before diffing
cmd/helm3.go	Added updateDependencies helper function to execute helm dependency update command

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-15T03:05:42Z

+ return err
+ } else {
+ fmt.Println(string(output))
+ }


[nitpick] The 'else' clause is unnecessary here since the 'if' block returns early on error. Consider removing the 'else' and unindenting the output printing code for better readability.
Suggested change
}
}
fmt.Println(string(output))

Copilot · 2025-08-15T03:05:42Z

+ if err != nil {
+ return err
+ } else {
+ fmt.Println(string(output))


[nitpick] The dependency update output is printed to stdout without any context or formatting. Consider adding a prefix like 'Dependency update:' or using a logger to maintain consistency with other command output formatting in the codebase.
Suggested change
fmt.Println(string(output))
log.Printf("Dependency update: %s", string(output))

yxxhero · 2026-04-26T10:03:39Z

@copilot resolve the merge conflicts in this pull request

kamilswiec · 2025-04-28T19:51:25Z

When using helm diff upgrade command when chart dependencies in charts are absent you have to add run helm dep up chart.

I want to be able to pass most of the arguments that I also use in helm upgrade command. This allows me to reduce duplication and ensure helm diff upgrade uses the same flags as helm upgrade be passing the same ${args} variable.

Tested with helm version 3.17.1.

Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero · 2025-04-28T22:57:26Z

@kamilswiec could you add some unit tests for this?

yxxhero · 2025-05-08T23:41:47Z

@kamilswiec hi. I will merge this if you can add some tests for this feature. and releae new version.

yxxhero · 2025-05-22T10:22:27Z

@kamilswiec ping.

Copilot

Pull Request Overview

This PR adds support for the --dependency-update flag to the helm diff upgrade command, allowing automatic dependency updates before diffing. This eliminates the need to manually run helm dep up chart when chart dependencies are missing and ensures consistency with helm upgrade command arguments.

Added --dependency-update boolean flag to the diff command
Implemented dependency update execution before running the diff operation
Added helper function to execute helm dependency update command

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
cmd/upgrade.go	Added dependencyUpdate flag field, command line flag registration, and logic to execute dependency update before diffing
cmd/helm3.go	Added updateDependencies helper function to execute helm dependency update command

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-15T03:05:42Z

+ return err
+ } else {
+ fmt.Println(string(output))
+ }


[nitpick] The 'else' clause is unnecessary here since the 'if' block returns early on error. Consider removing the 'else' and unindenting the output printing code for better readability.
Suggested change
}
}
fmt.Println(string(output))

Copilot · 2025-08-15T03:05:42Z

+ if err != nil {
+ return err
+ } else {
+ fmt.Println(string(output))


[nitpick] The dependency update output is printed to stdout without any context or formatting. Consider adding a prefix like 'Dependency update:' or using a logger to maintain consistency with other command output formatting in the codebase.
Suggested change
fmt.Println(string(output))
log.Printf("Dependency update: %s", string(output))

yxxhero · 2026-04-26T10:03:39Z

@copilot resolve the merge conflicts in this pull request

kamilswiec · 2025-04-28T19:51:25Z

When using helm diff upgrade command when chart dependencies in charts are absent you have to add run helm dep up chart.

I want to be able to pass most of the arguments that I also use in helm upgrade command. This allows me to reduce duplication and ensure helm diff upgrade uses the same flags as helm upgrade be passing the same ${args} variable.

Tested with helm version 3.17.1.

Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero · 2025-04-28T22:57:26Z

@kamilswiec could you add some unit tests for this?

yxxhero · 2025-05-08T23:41:47Z

@kamilswiec hi. I will merge this if you can add some tests for this feature. and releae new version.

yxxhero · 2025-05-22T10:22:27Z

@kamilswiec ping.

Copilot

Pull Request Overview

This PR adds support for the --dependency-update flag to the helm diff upgrade command, allowing automatic dependency updates before diffing. This eliminates the need to manually run helm dep up chart when chart dependencies are missing and ensures consistency with helm upgrade command arguments.

Added --dependency-update boolean flag to the diff command
Implemented dependency update execution before running the diff operation
Added helper function to execute helm dependency update command

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
cmd/upgrade.go	Added dependencyUpdate flag field, command line flag registration, and logic to execute dependency update before diffing
cmd/helm3.go	Added updateDependencies helper function to execute helm dependency update command

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-15T03:05:42Z

+ return err
+ } else {
+ fmt.Println(string(output))
+ }


[nitpick] The 'else' clause is unnecessary here since the 'if' block returns early on error. Consider removing the 'else' and unindenting the output printing code for better readability.
Suggested change
}
}
fmt.Println(string(output))

Copilot · 2025-08-15T03:05:42Z

+ if err != nil {
+ return err
+ } else {
+ fmt.Println(string(output))


[nitpick] The dependency update output is printed to stdout without any context or formatting. Consider adding a prefix like 'Dependency update:' or using a logger to maintain consistency with other command output formatting in the codebase.
Suggested change
fmt.Println(string(output))
log.Printf("Dependency update: %s", string(output))

yxxhero · 2026-04-26T10:03:39Z

@copilot resolve the merge conflicts in this pull request

kamilswiec · 2025-04-28T19:51:25Z

When using helm diff upgrade command when chart dependencies in charts are absent you have to add run helm dep up chart.

I want to be able to pass most of the arguments that I also use in helm upgrade command. This allows me to reduce duplication and ensure helm diff upgrade uses the same flags as helm upgrade be passing the same ${args} variable.

Tested with helm version 3.17.1.

Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero · 2025-04-28T22:57:26Z

@kamilswiec could you add some unit tests for this?

yxxhero · 2025-05-08T23:41:47Z

@kamilswiec hi. I will merge this if you can add some tests for this feature. and releae new version.

yxxhero · 2025-05-22T10:22:27Z

@kamilswiec ping.

Copilot

Pull Request Overview

This PR adds support for the --dependency-update flag to the helm diff upgrade command, allowing automatic dependency updates before diffing. This eliminates the need to manually run helm dep up chart when chart dependencies are missing and ensures consistency with helm upgrade command arguments.

Added --dependency-update boolean flag to the diff command
Implemented dependency update execution before running the diff operation
Added helper function to execute helm dependency update command

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
cmd/upgrade.go	Added dependencyUpdate flag field, command line flag registration, and logic to execute dependency update before diffing
cmd/helm3.go	Added updateDependencies helper function to execute helm dependency update command

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-15T03:05:42Z

+ return err
+ } else {
+ fmt.Println(string(output))
+ }


[nitpick] The 'else' clause is unnecessary here since the 'if' block returns early on error. Consider removing the 'else' and unindenting the output printing code for better readability.
Suggested change
}
}
fmt.Println(string(output))

Copilot · 2025-08-15T03:05:42Z

+ if err != nil {
+ return err
+ } else {
+ fmt.Println(string(output))


[nitpick] The dependency update output is printed to stdout without any context or formatting. Consider adding a prefix like 'Dependency update:' or using a logger to maintain consistency with other command output formatting in the codebase.
Suggested change
fmt.Println(string(output))
log.Printf("Dependency update: %s", string(output))

yxxhero · 2026-04-26T10:03:39Z

@copilot resolve the merge conflicts in this pull request

kamilswiec · 2025-04-28T19:51:25Z

When using helm diff upgrade command when chart dependencies in charts are absent you have to add run helm dep up chart.

I want to be able to pass most of the arguments that I also use in helm upgrade command. This allows me to reduce duplication and ensure helm diff upgrade uses the same flags as helm upgrade be passing the same ${args} variable.

Tested with helm version 3.17.1.

Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero · 2025-04-28T22:57:26Z

@kamilswiec could you add some unit tests for this?

yxxhero · 2025-05-08T23:41:47Z

@kamilswiec hi. I will merge this if you can add some tests for this feature. and releae new version.

yxxhero · 2025-05-22T10:22:27Z

@kamilswiec ping.

Copilot

Pull Request Overview

This PR adds support for the --dependency-update flag to the helm diff upgrade command, allowing automatic dependency updates before diffing. This eliminates the need to manually run helm dep up chart when chart dependencies are missing and ensures consistency with helm upgrade command arguments.

Added --dependency-update boolean flag to the diff command
Implemented dependency update execution before running the diff operation
Added helper function to execute helm dependency update command

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
cmd/upgrade.go	Added dependencyUpdate flag field, command line flag registration, and logic to execute dependency update before diffing
cmd/helm3.go	Added updateDependencies helper function to execute helm dependency update command

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-15T03:05:42Z

+ return err
+ } else {
+ fmt.Println(string(output))
+ }


[nitpick] The 'else' clause is unnecessary here since the 'if' block returns early on error. Consider removing the 'else' and unindenting the output printing code for better readability.
Suggested change
}
}
fmt.Println(string(output))

Copilot · 2025-08-15T03:05:42Z

+ if err != nil {
+ return err
+ } else {
+ fmt.Println(string(output))


[nitpick] The dependency update output is printed to stdout without any context or formatting. Consider adding a prefix like 'Dependency update:' or using a logger to maintain consistency with other command output formatting in the codebase.
Suggested change
fmt.Println(string(output))
log.Printf("Dependency update: %s", string(output))

yxxhero · 2026-04-26T10:03:39Z

@copilot resolve the merge conflicts in this pull request

kamilswiec · 2025-04-28T19:51:25Z

When using helm diff upgrade command when chart dependencies in charts are absent you have to add run helm dep up chart.

I want to be able to pass most of the arguments that I also use in helm upgrade command. This allows me to reduce duplication and ensure helm diff upgrade uses the same flags as helm upgrade be passing the same ${args} variable.

Tested with helm version 3.17.1.

Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero · 2025-04-28T22:57:26Z

@kamilswiec could you add some unit tests for this?

yxxhero · 2025-05-08T23:41:47Z

@kamilswiec hi. I will merge this if you can add some tests for this feature. and releae new version.

yxxhero · 2025-05-22T10:22:27Z

@kamilswiec ping.

Copilot

Pull Request Overview

This PR adds support for the --dependency-update flag to the helm diff upgrade command, allowing automatic dependency updates before diffing. This eliminates the need to manually run helm dep up chart when chart dependencies are missing and ensures consistency with helm upgrade command arguments.

Added --dependency-update boolean flag to the diff command
Implemented dependency update execution before running the diff operation
Added helper function to execute helm dependency update command

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
cmd/upgrade.go	Added dependencyUpdate flag field, command line flag registration, and logic to execute dependency update before diffing
cmd/helm3.go	Added updateDependencies helper function to execute helm dependency update command

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

Copilot · 2025-08-15T03:05:42Z

+ return err
+ } else {
+ fmt.Println(string(output))
+ }


[nitpick] The 'else' clause is unnecessary here since the 'if' block returns early on error. Consider removing the 'else' and unindenting the output printing code for better readability.
Suggested change
}
}
fmt.Println(string(output))

Copilot · 2025-08-15T03:05:42Z

+ if err != nil {
+ return err
+ } else {
+ fmt.Println(string(output))


[nitpick] The dependency update output is printed to stdout without any context or formatting. Consider adding a prefix like 'Dependency update:' or using a logger to maintain consistency with other command output formatting in the codebase.
Suggested change
fmt.Println(string(output))
log.Printf("Dependency update: %s", string(output))

yxxhero · 2026-04-26T10:03:39Z

@copilot resolve the merge conflicts in this pull request

feat:support --dependency-update before upgrade
15582ec
Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero requested a review from Copilot August 15, 2025 03:05

CopilotAI reviewed Aug 15, 2025
View reviewed changes

feat:support --dependency-update before upgrade
15582ec
Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero requested a review from Copilot August 15, 2025 03:05

CopilotAI reviewed Aug 15, 2025
View reviewed changes

feat:support --dependency-update before upgrade
15582ec
Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero requested a review from Copilot August 15, 2025 03:05

CopilotAI reviewed Aug 15, 2025
View reviewed changes

feat:support --dependency-update before upgrade
15582ec
Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero requested a review from Copilot August 15, 2025 03:05

CopilotAI reviewed Aug 15, 2025
View reviewed changes

feat:support --dependency-update before upgrade
15582ec
Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero requested a review from Copilot August 15, 2025 03:05

CopilotAI reviewed Aug 15, 2025
View reviewed changes

feat:support --dependency-update before upgrade
15582ec
Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero requested a review from Copilot August 15, 2025 03:05

CopilotAI reviewed Aug 15, 2025
View reviewed changes

feat:support --dependency-update before upgrade
15582ec
Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero requested a review from Copilot August 15, 2025 03:05

CopilotAI reviewed Aug 15, 2025
View reviewed changes

feat:support --dependency-update before upgrade
15582ec
Signed-off-by: kamilswiec <31224592+kamilswiec@users.noreply.github.com>

yxxhero requested a review from Copilot August 15, 2025 03:05

CopilotAI reviewed Aug 15, 2025
View reviewed changes

	fmt.Println(string(output))
	log.Printf("Dependency update: %s", string(output))

Conversation

kamilswiec commented Apr 28, 2025

Uh oh!

yxxhero commented Apr 28, 2025

Uh oh!

yxxhero commented May 8, 2025

Uh oh!

yxxhero commented May 22, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

CopilotAIAug 15, 2025

Choose a reason for hiding this comment

Uh oh!

CopilotAIAug 15, 2025

Choose a reason for hiding this comment

Uh oh!

yxxhero commented Apr 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kamilswiec commented Apr 28, 2025

Uh oh!

yxxhero commented Apr 28, 2025

Uh oh!

yxxhero commented May 8, 2025

Uh oh!

yxxhero commented May 22, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

CopilotAIAug 15, 2025

Choose a reason for hiding this comment

Uh oh!

CopilotAIAug 15, 2025

Choose a reason for hiding this comment

Uh oh!

yxxhero commented Apr 26, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

kamilswiec commented Apr 28, 2025

Uh oh!

yxxhero commented Apr 28, 2025

Uh oh!

yxxhero commented May 8, 2025

Uh oh!

yxxhero commented May 22, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

CopilotAIAug 15, 2025

Choose a reason for hiding this comment

Uh oh!

CopilotAIAug 15, 2025

Choose a reason for hiding this comment

Uh oh!