Uh oh!
There was an error while loading. Please reload this page.
Remediate CDC_Mortality_UnderlyingCause_SingleRace import - #2146
Remediate CDC_Mortality_UnderlyingCause_SingleRace import#2146shvngisingh wants to merge 2 commits into
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces validation configurations and golden data files for the FAO currency and exchange rate import, while also updating the US CDC single race import configuration, scripts, and documentation. The review feedback highlights a formatting issue in the newly added golden_observation.csv that could cause validation failures, and points out a documentation inconsistency in the README.md which is missing the newly introduced --output_counters argument.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
| "template_mcf": "output/underlyingcauseofdeath2018_2023singlerace.tmcf", | ||
| "cleaned_csv": "output/underlyingcauseofdeath2018_2023singlerace.csv" | ||
| "template_mcf": "output/underlyingcauseofdeath_singlerace.tmcf", | ||
| "node_mcf": "output/underlyingcauseofdeath_singlerace_stat_vars.mcf", |
There was a problem hiding this comment.
instead of adding here, lets create a CL for these new schema addition and bring them in
Remediates the CDC_Mortality_UnderlyingCause_SingleRace import pipeline.
Fix Validation: Added the generated statvar schema MCF to the manifest import_inputs to resolve missing reference warnings.
Auto-refresh robustness: Stripped hardcoded year range suffixes from scripts and manifest file paths to dynamically support future years without manual renaming.
Telemetry: Configured telemetry counter CSV generation.
Tested in dev environment .
Bucket: link