Uh oh!
There was an error while loading. Please reload this page.
Fix download script, add validation config and golden data for NYU TennesseDiabetes - #2150
Open
niveditasing wants to merge 5 commits into
Conversation
…nnessee Diabetes import - Updated download.py to use requests session with browser headers, HTTPAdapter retry policy, and graceful handling of 404 for unreleased years. - Added validation_config.json with deleted records threshold and goldens checks for summary report and observations. - Added golden_data/ with valid Tennessee state and county golden observations and summary report. - Updated manifest.json to include validation_config_file and golden_data source files.
Contributor
There was a problem hiding this comment.
Code Review
This pull request refactors the download script for Tennessee diabetes mortality data to use a persistent HTTP session with retries, adds golden data files, and introduces a validation configuration. The review feedback suggests improving the retry mechanism by raising HTTP errors inside the decorated fetch function so that retries are properly triggered on failures, and removing the redundant status check in the main download loop.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes:
testing results: https://storage.mtls.cloud.google.com/datcom-import-test/statvar_imports/nyu_diabetes/tennessee/NYU_Tennessee_Diabetes/2026_08_10T03_40_57_793708_07_00/input0/validation/validation_output.csv