Uh oh!
There was an error while loading. Please reload this page.
Follow-up to #2246: address PropertyGraph review comments - #2249
Merged
Conversation
rafal-hawrylak
commented
Aug 19, 2026
Collaborator
- Drop duplicate arity check in buildEndpoint. The post-defaults check in validateEndpointReferences catches the same case with a clearer message.
- Compare whole compiled objects in the minimal and relationship tests including the full graphBody string.
- Drop duplicate arity check in buildEndpoint. The post-defaults check in validateEndpointReferences catches the same case with a clearer message. - Compare whole compiled objects in the minimal and relationship tests including the full graphBody string.
kolina
approved these changes
Aug 19, 2026
Uh oh!
There was an error while loading. Please reload this page.
apilaskowski pushed a commit
that referenced
this pull request
Aug 19, 2026
rafal-hawrylak added a commit
that referenced
this pull request
Aug 19, 2026
Builds on top of #2246 (PropertyGraph action class) and #2249 (review follow-up). The class parsed and rendered a graph body but was not yet loaded from user projects or exposed to downstream code. - Session loading: main.ts finds `graph.yaml` files under `definitions/` and registers a PropertyGraph action per file. At most one graph.yaml is accepted per project. - Action index: actions/index.ts and session.ts expose PropertyGraph so downstream code treats it like tables and operations. - Emitter extensions: description and synonyms on both entities and relationships, fieldWildcard normalization for `fields: { importAll: true, except: [...] }`, and an OPTIONS clause on the graph carrying the graph description. - Proto: adds `is_default` to GraphLabel for the label wiring above. - Coverage: property_graph_test.ts grows for the new normalization and emitter behavior, and main_test.ts adds session-level tests plus a propertyGraph case in the shared test-helper switch. Older `dataformCoreVersion` values silently skip PropertyGraph files so projects pinning an earlier core do not break at load time.
rafal-hawrylak added a commit
that referenced
this pull request
Aug 20, 2026
Builds on top of #2246 (PropertyGraph action class) and #2249 (review follow-up). The class parsed and rendered a graph body but was not yet loaded from user projects or exposed to downstream code. - Session loading: main.ts finds `graph.yaml` files under `definitions/` and registers a PropertyGraph action per file. At most one graph.yaml is accepted per project. - Action index: actions/index.ts and session.ts expose PropertyGraph so downstream code treats it like tables and operations. - Emitter extensions: description and synonyms on both entities and relationships, fieldWildcard normalization for `fields: { importAll: true, except: [...] }`, and an OPTIONS clause on the graph carrying the graph description. - Proto: adds `is_default` to GraphLabel for the label wiring above. - Coverage: property_graph_test.ts grows for the new normalization and emitter behavior, and main_test.ts adds session-level tests plus a propertyGraph case in the shared test-helper switch. Older `dataformCoreVersion` values silently skip PropertyGraph files so projects pinning an earlier core do not break at load time.
rafal-hawrylak added a commit
that referenced
this pull request
Aug 20, 2026
Builds on top of #2246 (PropertyGraph action class) and #2249 (review follow-up). The class parsed and rendered a graph body but was not yet loaded from user projects or exposed to downstream code. - Session loading: main.ts finds `graph.yaml` files under `definitions/` and registers a PropertyGraph action per file. At most one graph.yaml is accepted per project. - Action index: actions/index.ts and session.ts expose PropertyGraph so downstream code treats it like tables and operations. - Emitter extensions: description and synonyms on both entities and relationships, fieldWildcard normalization for `fields: { importAll: true, except: [...] }`, and an OPTIONS clause on the graph carrying the graph description. - Proto: adds `is_default` to GraphLabel for the label wiring above. - Coverage: property_graph_test.ts grows for the new normalization and emitter behavior, and main_test.ts adds session-level tests plus a propertyGraph case in the shared test-helper switch. Older `dataformCoreVersion` values silently skip PropertyGraph files so projects pinning an earlier core do not break at load time.
rafal-hawrylak added a commit
that referenced
this pull request
Aug 20, 2026
Builds on top of #2246 (PropertyGraph action class) and #2249 (review follow-up). The class parsed and rendered a graph body but was not yet loaded from user projects or exposed to downstream code. - Session loading: main.ts finds `graph.yaml` files under `definitions/` and registers a PropertyGraph action per file. At most one graph.yaml is accepted per project. - Action index: actions/index.ts and session.ts expose PropertyGraph so downstream code treats it like tables and operations. - Emitter extensions: description and synonyms on both entities and relationships, fieldWildcard normalization for `fields: { importAll: true, except: [...] }`, and an OPTIONS clause on the graph carrying the graph description. - Proto: adds `is_default` to GraphLabel for the label wiring above. - Coverage: property_graph_test.ts grows for the new normalization and emitter behavior, and main_test.ts adds session-level tests plus a propertyGraph case in the shared test-helper switch. Older `dataformCoreVersion` values silently skip PropertyGraph files so projects pinning an earlier core do not break at load time.
rafal-hawrylak added a commit
that referenced
this pull request
Aug 21, 2026
Builds on top of #2246 (PropertyGraph action class) and #2249 (review follow-up). The class parsed and rendered a graph body but was not yet loaded from user projects or exposed to downstream code. - Session loading: main.ts finds `graph.yaml` files under `definitions/` and registers a PropertyGraph action per file. At most one graph.yaml is accepted per project. - Action index: actions/index.ts and session.ts expose PropertyGraph so downstream code treats it like tables and operations. - Emitter extensions: description and synonyms on both entities and relationships, fieldWildcard normalization for `fields: { importAll: true, except: [...] }`, and an OPTIONS clause on the graph carrying the graph description. - Proto: adds `is_default` to GraphLabel for the label wiring above. - Coverage: property_graph_test.ts grows for the new normalization and emitter behavior, and main_test.ts adds session-level tests plus a propertyGraph case in the shared test-helper switch. Older `dataformCoreVersion` values silently skip PropertyGraph files so projects pinning an earlier core do not break at load time.
rafal-hawrylak added a commit
that referenced
this pull request
Aug 21, 2026
Builds on top of #2246 (PropertyGraph action class) and #2249 (review follow-up). The class parsed and rendered a graph body but was not yet loaded from user projects or exposed to downstream code. - Session loading: main.ts finds `graph.yaml` files under `definitions/` and registers a PropertyGraph action per file. At most one graph.yaml is accepted per project. - Action index: actions/index.ts and session.ts expose PropertyGraph so downstream code treats it like tables and operations. - Emitter extensions: description and synonyms on both entities and relationships, fieldWildcard normalization for `fields: { importAll: true, except: [...] }`, and an OPTIONS clause on the graph carrying the graph description. - Proto: adds `is_default` to GraphLabel for the label wiring above. - Coverage: property_graph_test.ts grows for the new normalization and emitter behavior, and main_test.ts adds session-level tests plus a propertyGraph case in the shared test-helper switch. Older `dataformCoreVersion` values silently skip PropertyGraph files so projects pinning an earlier core do not break at load time.
rafal-hawrylak added a commit
that referenced
this pull request
Aug 24, 2026
Builds on top of #2246 (PropertyGraph action class) and #2249 (review follow-up). The class parsed and rendered a graph body but was not yet loaded from user projects or exposed to downstream code. - Session loading: main.ts finds `graph.yaml` files under `definitions/` and registers a PropertyGraph action per file. At most one graph.yaml is accepted per project. - Action index: actions/index.ts and session.ts expose PropertyGraph so downstream code treats it like tables and operations. - Emitter extensions: description and synonyms on both entities and relationships, fieldWildcard normalization for `fields: { importAll: true, except: [...] }`, and an OPTIONS clause on the graph carrying the graph description. - Proto: adds `is_default` to GraphLabel for the label wiring above. - Coverage: property_graph_test.ts grows for the new normalization and emitter behavior, and main_test.ts adds session-level tests plus a propertyGraph case in the shared test-helper switch. Older `dataformCoreVersion` values silently skip PropertyGraph files so projects pinning an earlier core do not break at load time. Porting the changes from PR (#2251)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.