Skip to content

Upgrade dependencies - #40

Open
NinaDen wants to merge 9 commits into
masterfrom
upgrade-dependencies
Open

Upgrade dependencies#40
NinaDen wants to merge 9 commits into
masterfrom
upgrade-dependencies

Conversation

@NinaDen

@NinaDenNinaDen commented Jul 8, 2022

Copy link
Copy Markdown

Changes:

  • Upgrade version of react-scripts
  • Fix webpack config according to changed in react-scripts 5
  • Add test of dreact on node 16
  • Resolve dependency tree errors

TODO:

  • Fix linter error on node 16 in cli/environment/webpack.config.js, line 47. Linter for node 12 and 14 and linter on node 16 ask for the opposite things:
  • node 12 and 14:
config.module.rules[1].oneOf[3].options.cacheIdentifier += getCacheIdentifier()
  • node 16:
config.module.rules[1].oneOf[3].options.cacheIdentifier +=
getCacheIdentifier()

@NinaDenNinaDen added the WIP label Jul 8, 2022
@NinaDen
NinaDen requested review from atatarenko and ezhloboJuly 8, 2022 12:05
@NinaDen
NinaDenforce-pushed the upgrade-dependencies branch 2 times, most recently from 31fe7e8 to 1154a59CompareJuly 13, 2022 08:00
@NinaDen
NinaDenforce-pushed the upgrade-dependencies branch from 57f3357 to da7ebf3CompareJuly 21, 2022 10:03
@atatarenko

Copy link
Copy Markdown

Hey @NinaDen – I see you get the thing from to-do list done but this PR still stays WIP. Can you confirm it's still WIP or it's ready for review?

@NinaDen

Copy link
Copy Markdown
Author

Hey @NinaDen – I see you get the thing from to-do list done but this PR still stays WIP. Can you confirm it's still WIP or it's ready for review?

It's almost finished, I want to change eslint-config-datarockets version to new one and eslint version

Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@NinaDen@atatarenko