feat: extension for remote R session management by ymarcon · Pull Request #24 · datashield/DSI

ymarcon · 2025-10-15T07:44:59Z

Implementation of #23

…n to handle R sessions properly

…e not having session support)

Copilot

Pull Request Overview

This PR implements remote R session management functionality for DataSHIELD, adding the ability to create, check, and monitor remote R sessions asynchronously. It introduces a new DSSession class and associated methods for session state management.

Adds DSSession class and related generics (dsIsReady, dsStateMessage, dsHasSession, dsSession)
Implements datashield.sessions() function for managing multiple connections with async support and progress tracking
Integrates session management into existing DataSHIELD workflows (login, assign, aggregate operations)

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
R/DSSession.R	New file defining DSSession class and core session management generics
R/DSConnection.R	Extended with session-related methods and improved documentation
R/datashield.sessions.R	New session management function with async support and callback handling
R/datashield.login.R	Simplified login logic and integrated workspace restoration
R/datashield.assign.R	Added session initialization calls to assignment functions
R/datashield.aggregate.R	Added session initialization call to aggregate function
R/datashield.workspace.R	Added session initialization to workspace operations
R/datashield.symbol.R	Added session initialization to symbol listing
man/*.Rd	Generated documentation files for new functions and updated cross-references
NAMESPACE	Exported new session-related functions and classes
DESCRIPTION	Updated collate order to include new session files

Comments suppressed due to low confidence (1)

R/datashield.assign.R:272

The datashield.assign.resource function is missing a datashield.sessions(conns) call at the beginning, which is inconsistent with other assignment functions like datashield.assign.table and datashield.assign.expr.

datashield.assign.resource <- function(conns, symbol, resource, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

timcadman

Looks good Yannick. Only suggestion is to consider refactoring datashield.session to reduce repetition and make it a bit more readable. I know this is in the same style as other DSI functions, so I leave this as an optional suggestion for you

timcadman · 2025-10-28T15:14:57Z

+#' }
+#'
+#' @export
+datashield.sessions <- function(conns, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {


Could this be refactored? These nested ifs within the for loop are quite hard to read and difficult to debug if something goes wrong.

timcadman · 2025-10-28T15:15:43Z

+ tryCatch({
+ sessions[[n]] <- dsSession(fconns[[n]], async=async)
+ }, error = function(e) {
+ .appendError(n, conditionMessage(e))


This is repeated - could you break into a separate helper function which is then called in the error part of the trycatch?

ymarcon · 2025-10-15T07:44:59Z

Implementation of #23

…n to handle R sessions properly

…e not having session support)

Copilot

Pull Request Overview

This PR implements remote R session management functionality for DataSHIELD, adding the ability to create, check, and monitor remote R sessions asynchronously. It introduces a new DSSession class and associated methods for session state management.

Adds DSSession class and related generics (dsIsReady, dsStateMessage, dsHasSession, dsSession)
Implements datashield.sessions() function for managing multiple connections with async support and progress tracking
Integrates session management into existing DataSHIELD workflows (login, assign, aggregate operations)

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
R/DSSession.R	New file defining DSSession class and core session management generics
R/DSConnection.R	Extended with session-related methods and improved documentation
R/datashield.sessions.R	New session management function with async support and callback handling
R/datashield.login.R	Simplified login logic and integrated workspace restoration
R/datashield.assign.R	Added session initialization calls to assignment functions
R/datashield.aggregate.R	Added session initialization call to aggregate function
R/datashield.workspace.R	Added session initialization to workspace operations
R/datashield.symbol.R	Added session initialization to symbol listing
man/*.Rd	Generated documentation files for new functions and updated cross-references
NAMESPACE	Exported new session-related functions and classes
DESCRIPTION	Updated collate order to include new session files

Comments suppressed due to low confidence (1)

R/datashield.assign.R:272

The datashield.assign.resource function is missing a datashield.sessions(conns) call at the beginning, which is inconsistent with other assignment functions like datashield.assign.table and datashield.assign.expr.

datashield.assign.resource <- function(conns, symbol, resource, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

timcadman

Looks good Yannick. Only suggestion is to consider refactoring datashield.session to reduce repetition and make it a bit more readable. I know this is in the same style as other DSI functions, so I leave this as an optional suggestion for you

timcadman · 2025-10-28T15:14:57Z

+#' }
+#'
+#' @export
+datashield.sessions <- function(conns, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {


Could this be refactored? These nested ifs within the for loop are quite hard to read and difficult to debug if something goes wrong.

timcadman · 2025-10-28T15:15:43Z

+ tryCatch({
+ sessions[[n]] <- dsSession(fconns[[n]], async=async)
+ }, error = function(e) {
+ .appendError(n, conditionMessage(e))


This is repeated - could you break into a separate helper function which is then called in the error part of the trycatch?

ymarcon · 2025-10-15T07:44:59Z

Implementation of #23

…n to handle R sessions properly

…e not having session support)

Copilot

Pull Request Overview

This PR implements remote R session management functionality for DataSHIELD, adding the ability to create, check, and monitor remote R sessions asynchronously. It introduces a new DSSession class and associated methods for session state management.

Adds DSSession class and related generics (dsIsReady, dsStateMessage, dsHasSession, dsSession)
Implements datashield.sessions() function for managing multiple connections with async support and progress tracking
Integrates session management into existing DataSHIELD workflows (login, assign, aggregate operations)

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
R/DSSession.R	New file defining DSSession class and core session management generics
R/DSConnection.R	Extended with session-related methods and improved documentation
R/datashield.sessions.R	New session management function with async support and callback handling
R/datashield.login.R	Simplified login logic and integrated workspace restoration
R/datashield.assign.R	Added session initialization calls to assignment functions
R/datashield.aggregate.R	Added session initialization call to aggregate function
R/datashield.workspace.R	Added session initialization to workspace operations
R/datashield.symbol.R	Added session initialization to symbol listing
man/*.Rd	Generated documentation files for new functions and updated cross-references
NAMESPACE	Exported new session-related functions and classes
DESCRIPTION	Updated collate order to include new session files

Comments suppressed due to low confidence (1)

R/datashield.assign.R:272

The datashield.assign.resource function is missing a datashield.sessions(conns) call at the beginning, which is inconsistent with other assignment functions like datashield.assign.table and datashield.assign.expr.

datashield.assign.resource <- function(conns, symbol, resource, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

timcadman

Looks good Yannick. Only suggestion is to consider refactoring datashield.session to reduce repetition and make it a bit more readable. I know this is in the same style as other DSI functions, so I leave this as an optional suggestion for you

timcadman · 2025-10-28T15:14:57Z

+#' }
+#'
+#' @export
+datashield.sessions <- function(conns, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {


Could this be refactored? These nested ifs within the for loop are quite hard to read and difficult to debug if something goes wrong.

timcadman · 2025-10-28T15:15:43Z

+ tryCatch({
+ sessions[[n]] <- dsSession(fconns[[n]], async=async)
+ }, error = function(e) {
+ .appendError(n, conditionMessage(e))


This is repeated - could you break into a separate helper function which is then called in the error part of the trycatch?

ymarcon · 2025-10-15T07:44:59Z

Implementation of #23

…n to handle R sessions properly

…e not having session support)

Copilot

Pull Request Overview

This PR implements remote R session management functionality for DataSHIELD, adding the ability to create, check, and monitor remote R sessions asynchronously. It introduces a new DSSession class and associated methods for session state management.

Adds DSSession class and related generics (dsIsReady, dsStateMessage, dsHasSession, dsSession)
Implements datashield.sessions() function for managing multiple connections with async support and progress tracking
Integrates session management into existing DataSHIELD workflows (login, assign, aggregate operations)

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
R/DSSession.R	New file defining DSSession class and core session management generics
R/DSConnection.R	Extended with session-related methods and improved documentation
R/datashield.sessions.R	New session management function with async support and callback handling
R/datashield.login.R	Simplified login logic and integrated workspace restoration
R/datashield.assign.R	Added session initialization calls to assignment functions
R/datashield.aggregate.R	Added session initialization call to aggregate function
R/datashield.workspace.R	Added session initialization to workspace operations
R/datashield.symbol.R	Added session initialization to symbol listing
man/*.Rd	Generated documentation files for new functions and updated cross-references
NAMESPACE	Exported new session-related functions and classes
DESCRIPTION	Updated collate order to include new session files

Comments suppressed due to low confidence (1)

R/datashield.assign.R:272

The datashield.assign.resource function is missing a datashield.sessions(conns) call at the beginning, which is inconsistent with other assignment functions like datashield.assign.table and datashield.assign.expr.

datashield.assign.resource <- function(conns, symbol, resource, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

timcadman

Looks good Yannick. Only suggestion is to consider refactoring datashield.session to reduce repetition and make it a bit more readable. I know this is in the same style as other DSI functions, so I leave this as an optional suggestion for you

timcadman · 2025-10-28T15:14:57Z

+#' }
+#'
+#' @export
+datashield.sessions <- function(conns, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {


Could this be refactored? These nested ifs within the for loop are quite hard to read and difficult to debug if something goes wrong.

timcadman · 2025-10-28T15:15:43Z

+ tryCatch({
+ sessions[[n]] <- dsSession(fconns[[n]], async=async)
+ }, error = function(e) {
+ .appendError(n, conditionMessage(e))


This is repeated - could you break into a separate helper function which is then called in the error part of the trycatch?

ymarcon · 2025-10-15T07:44:59Z

Implementation of #23

…n to handle R sessions properly

…e not having session support)

Copilot

Pull Request Overview

This PR implements remote R session management functionality for DataSHIELD, adding the ability to create, check, and monitor remote R sessions asynchronously. It introduces a new DSSession class and associated methods for session state management.

Adds DSSession class and related generics (dsIsReady, dsStateMessage, dsHasSession, dsSession)
Implements datashield.sessions() function for managing multiple connections with async support and progress tracking
Integrates session management into existing DataSHIELD workflows (login, assign, aggregate operations)

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
R/DSSession.R	New file defining DSSession class and core session management generics
R/DSConnection.R	Extended with session-related methods and improved documentation
R/datashield.sessions.R	New session management function with async support and callback handling
R/datashield.login.R	Simplified login logic and integrated workspace restoration
R/datashield.assign.R	Added session initialization calls to assignment functions
R/datashield.aggregate.R	Added session initialization call to aggregate function
R/datashield.workspace.R	Added session initialization to workspace operations
R/datashield.symbol.R	Added session initialization to symbol listing
man/*.Rd	Generated documentation files for new functions and updated cross-references
NAMESPACE	Exported new session-related functions and classes
DESCRIPTION	Updated collate order to include new session files

Comments suppressed due to low confidence (1)

R/datashield.assign.R:272

The datashield.assign.resource function is missing a datashield.sessions(conns) call at the beginning, which is inconsistent with other assignment functions like datashield.assign.table and datashield.assign.expr.

datashield.assign.resource <- function(conns, symbol, resource, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

timcadman

Looks good Yannick. Only suggestion is to consider refactoring datashield.session to reduce repetition and make it a bit more readable. I know this is in the same style as other DSI functions, so I leave this as an optional suggestion for you

timcadman · 2025-10-28T15:14:57Z

+#' }
+#'
+#' @export
+datashield.sessions <- function(conns, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {


Could this be refactored? These nested ifs within the for loop are quite hard to read and difficult to debug if something goes wrong.

timcadman · 2025-10-28T15:15:43Z

+ tryCatch({
+ sessions[[n]] <- dsSession(fconns[[n]], async=async)
+ }, error = function(e) {
+ .appendError(n, conditionMessage(e))


This is repeated - could you break into a separate helper function which is then called in the error part of the trycatch?

ymarcon · 2025-10-15T07:44:59Z

Implementation of #23

…n to handle R sessions properly

…e not having session support)

Copilot

Pull Request Overview

This PR implements remote R session management functionality for DataSHIELD, adding the ability to create, check, and monitor remote R sessions asynchronously. It introduces a new DSSession class and associated methods for session state management.

Adds DSSession class and related generics (dsIsReady, dsStateMessage, dsHasSession, dsSession)
Implements datashield.sessions() function for managing multiple connections with async support and progress tracking
Integrates session management into existing DataSHIELD workflows (login, assign, aggregate operations)

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
R/DSSession.R	New file defining DSSession class and core session management generics
R/DSConnection.R	Extended with session-related methods and improved documentation
R/datashield.sessions.R	New session management function with async support and callback handling
R/datashield.login.R	Simplified login logic and integrated workspace restoration
R/datashield.assign.R	Added session initialization calls to assignment functions
R/datashield.aggregate.R	Added session initialization call to aggregate function
R/datashield.workspace.R	Added session initialization to workspace operations
R/datashield.symbol.R	Added session initialization to symbol listing
man/*.Rd	Generated documentation files for new functions and updated cross-references
NAMESPACE	Exported new session-related functions and classes
DESCRIPTION	Updated collate order to include new session files

Comments suppressed due to low confidence (1)

R/datashield.assign.R:272

The datashield.assign.resource function is missing a datashield.sessions(conns) call at the beginning, which is inconsistent with other assignment functions like datashield.assign.table and datashield.assign.expr.

datashield.assign.resource <- function(conns, symbol, resource, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

timcadman

Looks good Yannick. Only suggestion is to consider refactoring datashield.session to reduce repetition and make it a bit more readable. I know this is in the same style as other DSI functions, so I leave this as an optional suggestion for you

timcadman · 2025-10-28T15:14:57Z

+#' }
+#'
+#' @export
+datashield.sessions <- function(conns, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {


Could this be refactored? These nested ifs within the for loop are quite hard to read and difficult to debug if something goes wrong.

timcadman · 2025-10-28T15:15:43Z

+ tryCatch({
+ sessions[[n]] <- dsSession(fconns[[n]], async=async)
+ }, error = function(e) {
+ .appendError(n, conditionMessage(e))


This is repeated - could you break into a separate helper function which is then called in the error part of the trycatch?

ymarcon · 2025-10-15T07:44:59Z

Implementation of #23

…n to handle R sessions properly

…e not having session support)

Copilot

Pull Request Overview

This PR implements remote R session management functionality for DataSHIELD, adding the ability to create, check, and monitor remote R sessions asynchronously. It introduces a new DSSession class and associated methods for session state management.

Adds DSSession class and related generics (dsIsReady, dsStateMessage, dsHasSession, dsSession)
Implements datashield.sessions() function for managing multiple connections with async support and progress tracking
Integrates session management into existing DataSHIELD workflows (login, assign, aggregate operations)

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
R/DSSession.R	New file defining DSSession class and core session management generics
R/DSConnection.R	Extended with session-related methods and improved documentation
R/datashield.sessions.R	New session management function with async support and callback handling
R/datashield.login.R	Simplified login logic and integrated workspace restoration
R/datashield.assign.R	Added session initialization calls to assignment functions
R/datashield.aggregate.R	Added session initialization call to aggregate function
R/datashield.workspace.R	Added session initialization to workspace operations
R/datashield.symbol.R	Added session initialization to symbol listing
man/*.Rd	Generated documentation files for new functions and updated cross-references
NAMESPACE	Exported new session-related functions and classes
DESCRIPTION	Updated collate order to include new session files

Comments suppressed due to low confidence (1)

R/datashield.assign.R:272

The datashield.assign.resource function is missing a datashield.sessions(conns) call at the beginning, which is inconsistent with other assignment functions like datashield.assign.table and datashield.assign.expr.

datashield.assign.resource <- function(conns, symbol, resource, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

timcadman

Looks good Yannick. Only suggestion is to consider refactoring datashield.session to reduce repetition and make it a bit more readable. I know this is in the same style as other DSI functions, so I leave this as an optional suggestion for you

timcadman · 2025-10-28T15:14:57Z

+#' }
+#'
+#' @export
+datashield.sessions <- function(conns, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {


Could this be refactored? These nested ifs within the for loop are quite hard to read and difficult to debug if something goes wrong.

timcadman · 2025-10-28T15:15:43Z

+ tryCatch({
+ sessions[[n]] <- dsSession(fconns[[n]], async=async)
+ }, error = function(e) {
+ .appendError(n, conditionMessage(e))


This is repeated - could you break into a separate helper function which is then called in the error part of the trycatch?

ymarcon · 2025-10-15T07:44:59Z

Implementation of #23

…n to handle R sessions properly

…e not having session support)

Copilot

Pull Request Overview

This PR implements remote R session management functionality for DataSHIELD, adding the ability to create, check, and monitor remote R sessions asynchronously. It introduces a new DSSession class and associated methods for session state management.

Adds DSSession class and related generics (dsIsReady, dsStateMessage, dsHasSession, dsSession)
Implements datashield.sessions() function for managing multiple connections with async support and progress tracking
Integrates session management into existing DataSHIELD workflows (login, assign, aggregate operations)

Reviewed Changes

Copilot reviewed 41 out of 41 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
R/DSSession.R	New file defining DSSession class and core session management generics
R/DSConnection.R	Extended with session-related methods and improved documentation
R/datashield.sessions.R	New session management function with async support and callback handling
R/datashield.login.R	Simplified login logic and integrated workspace restoration
R/datashield.assign.R	Added session initialization calls to assignment functions
R/datashield.aggregate.R	Added session initialization call to aggregate function
R/datashield.workspace.R	Added session initialization to workspace operations
R/datashield.symbol.R	Added session initialization to symbol listing
man/*.Rd	Generated documentation files for new functions and updated cross-references
NAMESPACE	Exported new session-related functions and classes
DESCRIPTION	Updated collate order to include new session files

Comments suppressed due to low confidence (1)

R/datashield.assign.R:272

The datashield.assign.resource function is missing a datashield.sessions(conns) call at the beginning, which is inconsistent with other assignment functions like datashield.assign.table and datashield.assign.expr.

datashield.assign.resource <- function(conns, symbol, resource, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

timcadman

Looks good Yannick. Only suggestion is to consider refactoring datashield.session to reduce repetition and make it a bit more readable. I know this is in the same style as other DSI functions, so I leave this as an optional suggestion for you

timcadman · 2025-10-28T15:14:57Z

+#' }
+#'
+#' @export
+datashield.sessions <- function(conns, async=TRUE, success=NULL, error=NULL, errors.print = getOption("datashield.errors.print", FALSE)) {


Could this be refactored? These nested ifs within the for loop are quite hard to read and difficult to debug if something goes wrong.

timcadman · 2025-10-28T15:15:43Z

+ tryCatch({
+ sessions[[n]] <- dsSession(fconns[[n]], async=async)
+ }, error = function(e) {
+ .appendError(n, conditionMessage(e))


This is repeated - could you break into a separate helper function which is then called in the error part of the trycatch?

ymarcon added 5 commits October 10, 2025 17:26

feat: added session related S4 methods
acaf276

feat: datashield.sessions added
e32dd59

feat: use workspace restore and assignment functions in login functio…
58593d5
…n to handle R sessions properly

feat: display state of each R server
a865bd7

feat: ensure backward compatibility with older DSI implementations (i…
31bf610
…e not having session support)

ymarcon requested a review from Copilot October 15, 2025 07:44

CopilotAI reviewed Oct 15, 2025
View reviewed changes

Comment threadR/datashield.login.R Outdated
Comment threadR/datashield.login.R Outdated

ymarcon added 2 commits October 15, 2025 09:47

fix: typo
e5c4df9

fix: ensure R sessions before perfoming resource assignment
74e61bf

ymarcon requested a review from timcadman October 15, 2025 07:56

ymarcon added 2 commits October 25, 2025 08:08

chore: update roxygen
08d9581

fix: update progress when not async session creation
da2a359

timcadman approved these changes Oct 28, 2025
View reviewed changes

ymarcon merged commit 61c027b into masterOct 30, 2025
3 checks passed

ymarcon deleted the feat/session branch October 30, 2025 08:17

ymarcon added 5 commits October 10, 2025 17:26

feat: added session related S4 methods
acaf276

feat: datashield.sessions added
e32dd59

feat: use workspace restore and assignment functions in login functio…
58593d5
…n to handle R sessions properly

feat: display state of each R server
a865bd7

feat: ensure backward compatibility with older DSI implementations (i…
31bf610
…e not having session support)

ymarcon requested a review from Copilot October 15, 2025 07:44

CopilotAI reviewed Oct 15, 2025
View reviewed changes

Comment threadR/datashield.login.R Outdated
Comment threadR/datashield.login.R Outdated

ymarcon added 2 commits October 15, 2025 09:47

fix: typo
e5c4df9

fix: ensure R sessions before perfoming resource assignment
74e61bf

ymarcon requested a review from timcadman October 15, 2025 07:56

ymarcon added 2 commits October 25, 2025 08:08

chore: update roxygen
08d9581

fix: update progress when not async session creation
da2a359

timcadman approved these changes Oct 28, 2025
View reviewed changes

ymarcon merged commit 61c027b into masterOct 30, 2025
3 checks passed

ymarcon deleted the feat/session branch October 30, 2025 08:17

ymarcon added 5 commits October 10, 2025 17:26

feat: added session related S4 methods
acaf276

feat: datashield.sessions added
e32dd59

feat: use workspace restore and assignment functions in login functio…
58593d5
…n to handle R sessions properly

feat: display state of each R server
a865bd7

feat: ensure backward compatibility with older DSI implementations (i…
31bf610
…e not having session support)

ymarcon requested a review from Copilot October 15, 2025 07:44

CopilotAI reviewed Oct 15, 2025
View reviewed changes

Comment threadR/datashield.login.R Outdated
Comment threadR/datashield.login.R Outdated

ymarcon added 2 commits October 15, 2025 09:47

fix: typo
e5c4df9

fix: ensure R sessions before perfoming resource assignment
74e61bf

ymarcon requested a review from timcadman October 15, 2025 07:56

ymarcon added 2 commits October 25, 2025 08:08

chore: update roxygen
08d9581

fix: update progress when not async session creation
da2a359

timcadman approved these changes Oct 28, 2025
View reviewed changes

ymarcon merged commit 61c027b into masterOct 30, 2025
3 checks passed

ymarcon deleted the feat/session branch October 30, 2025 08:17

ymarcon added 5 commits October 10, 2025 17:26

feat: added session related S4 methods
acaf276

feat: datashield.sessions added
e32dd59

feat: use workspace restore and assignment functions in login functio…
58593d5
…n to handle R sessions properly

feat: display state of each R server
a865bd7

feat: ensure backward compatibility with older DSI implementations (i…
31bf610
…e not having session support)

ymarcon requested a review from Copilot October 15, 2025 07:44

CopilotAI reviewed Oct 15, 2025
View reviewed changes

Comment threadR/datashield.login.R Outdated
Comment threadR/datashield.login.R Outdated

ymarcon added 2 commits October 15, 2025 09:47

fix: typo
e5c4df9

fix: ensure R sessions before perfoming resource assignment
74e61bf

ymarcon requested a review from timcadman October 15, 2025 07:56

ymarcon added 2 commits October 25, 2025 08:08

chore: update roxygen
08d9581

fix: update progress when not async session creation
da2a359

timcadman approved these changes Oct 28, 2025
View reviewed changes

ymarcon merged commit 61c027b into masterOct 30, 2025
3 checks passed

ymarcon deleted the feat/session branch October 30, 2025 08:17

ymarcon added 5 commits October 10, 2025 17:26

feat: added session related S4 methods
acaf276

feat: datashield.sessions added
e32dd59

feat: use workspace restore and assignment functions in login functio…
58593d5
…n to handle R sessions properly

feat: display state of each R server
a865bd7

feat: ensure backward compatibility with older DSI implementations (i…
31bf610
…e not having session support)

ymarcon requested a review from Copilot October 15, 2025 07:44

CopilotAI reviewed Oct 15, 2025
View reviewed changes

Comment threadR/datashield.login.R Outdated
Comment threadR/datashield.login.R Outdated

ymarcon added 2 commits October 15, 2025 09:47

fix: typo
e5c4df9

fix: ensure R sessions before perfoming resource assignment
74e61bf

ymarcon requested a review from timcadman October 15, 2025 07:56

ymarcon added 2 commits October 25, 2025 08:08

chore: update roxygen
08d9581

fix: update progress when not async session creation
da2a359

timcadman approved these changes Oct 28, 2025
View reviewed changes

ymarcon merged commit 61c027b into masterOct 30, 2025
3 checks passed

ymarcon deleted the feat/session branch October 30, 2025 08:17

ymarcon added 5 commits October 10, 2025 17:26

feat: added session related S4 methods
acaf276

feat: datashield.sessions added
e32dd59

feat: use workspace restore and assignment functions in login functio…
58593d5
…n to handle R sessions properly

feat: display state of each R server
a865bd7

feat: ensure backward compatibility with older DSI implementations (i…
31bf610
…e not having session support)

ymarcon requested a review from Copilot October 15, 2025 07:44

CopilotAI reviewed Oct 15, 2025
View reviewed changes

Comment threadR/datashield.login.R Outdated
Comment threadR/datashield.login.R Outdated

ymarcon added 2 commits October 15, 2025 09:47

fix: typo
e5c4df9

fix: ensure R sessions before perfoming resource assignment
74e61bf

ymarcon requested a review from timcadman October 15, 2025 07:56

ymarcon added 2 commits October 25, 2025 08:08

chore: update roxygen
08d9581

fix: update progress when not async session creation
da2a359

timcadman approved these changes Oct 28, 2025
View reviewed changes

ymarcon merged commit 61c027b into masterOct 30, 2025
3 checks passed

ymarcon deleted the feat/session branch October 30, 2025 08:17

ymarcon added 5 commits October 10, 2025 17:26

feat: added session related S4 methods
acaf276

feat: datashield.sessions added
e32dd59

feat: use workspace restore and assignment functions in login functio…
58593d5
…n to handle R sessions properly

feat: display state of each R server
a865bd7

feat: ensure backward compatibility with older DSI implementations (i…
31bf610
…e not having session support)

ymarcon requested a review from Copilot October 15, 2025 07:44

CopilotAI reviewed Oct 15, 2025
View reviewed changes

Comment threadR/datashield.login.R Outdated
Comment threadR/datashield.login.R Outdated

ymarcon added 2 commits October 15, 2025 09:47

fix: typo
e5c4df9

fix: ensure R sessions before perfoming resource assignment
74e61bf

ymarcon requested a review from timcadman October 15, 2025 07:56

ymarcon added 2 commits October 25, 2025 08:08

chore: update roxygen
08d9581

fix: update progress when not async session creation
da2a359

timcadman approved these changes Oct 28, 2025
View reviewed changes

ymarcon merged commit 61c027b into masterOct 30, 2025
3 checks passed

ymarcon deleted the feat/session branch October 30, 2025 08:17

ymarcon added 5 commits October 10, 2025 17:26

feat: added session related S4 methods
acaf276

feat: datashield.sessions added
e32dd59

feat: use workspace restore and assignment functions in login functio…
58593d5
…n to handle R sessions properly

feat: display state of each R server
a865bd7

feat: ensure backward compatibility with older DSI implementations (i…
31bf610
…e not having session support)

ymarcon requested a review from Copilot October 15, 2025 07:44

CopilotAI reviewed Oct 15, 2025
View reviewed changes

Comment threadR/datashield.login.R Outdated
Comment threadR/datashield.login.R Outdated

ymarcon added 2 commits October 15, 2025 09:47

fix: typo
e5c4df9

fix: ensure R sessions before perfoming resource assignment
74e61bf

ymarcon requested a review from timcadman October 15, 2025 07:56

ymarcon added 2 commits October 25, 2025 08:08

chore: update roxygen
08d9581

fix: update progress when not async session creation
da2a359

timcadman approved these changes Oct 28, 2025
View reviewed changes

ymarcon merged commit 61c027b into masterOct 30, 2025
3 checks passed

ymarcon deleted the feat/session branch October 30, 2025 08:17

Uh oh!

Conversation

ymarcon commented Oct 15, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

timcadman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ymarcon commented Oct 15, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

timcadman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

ymarcon commented Oct 15, 2025

Uh oh!

CopilotAI left a comment

Choose a reason for hiding this comment

Pull Request Overview

Reviewed Changes

Uh oh!

Uh oh!

Uh oh!

timcadman left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation