Uh oh!
There was an error while loading. Please reload this page.
feat: added filter by connection names to operations - #6
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds optional connection-name filtering (conn_names) to DSSession operations so callers can target a subset of active connections (and includes tests covering key filtered operations).
Changes:
- Added
conn_names: list[str] | Noneparameter to multipleDSSessionAPIs (tables, assignments, aggregation, workspace ops, close, etc.). - Implemented
_get_selected_connections()helper to centralize connection filtering. - Added a new test module validating filtering behavior across several operations.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 5 comments.
| File | Description |
|---|---|
datashield/api.py | Extends session APIs with conn_names filtering and adds _get_selected_connections(); adjusts close() and sessions() logic. |
tests/test_session_filters.py | Adds unit tests for filtered operations (tables, assign_expr, aggregate, workspace methods, close). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
Uh oh!
There was an error while loading. Please reload this page.
No description provided.