Uh oh!
There was an error while loading. Please reload this page.
add minimum matrix size to reduce disclosure risk - #500
Merged
Conversation
timcadman
marked this pull request as draft
July 23, 2026 15:05
timcadman
commented
Jul 23, 2026
ContributorAuthor
Sorry stuart this is a mess, just fixing it! |
timcadman
requested review from
StuartWheater
and removed request for
StuartWheaterJuly 23, 2026 15:06
timcadmanforce-pushed
the
fix/matrix-disclosure
branch
from
July 23, 2026 15:27
cec2dc2 to
7cb57fcComparetimcadman
marked this pull request as ready for review
July 23, 2026 15:28
timcadman
commented
Jul 23, 2026
ContributorAuthor
Ok fixed! |
StuartWheater
commented
Jul 23, 2026
Member
Ack. Will review after tests complete. |
StuartWheater
approved these changes
Jul 27, 2026
StuartWheater
left a comment
Member
There was a problem hiding this comment.
- I wonder if it does need a separate nfilter value, not reusing
subset - Gain we have the problem if the input matrix has been maliciously constructed.
timcadman
commented
Jul 27, 2026
ContributorAuthor
Agreed - nfiltersubset wasn't ideal, but it seemed a smaller change than adding a new filter. You're right - it doesn't protect from the malicious attack, hence why I included it in this disclosure profile. |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
matrixDetDS1is the only matrix aggregate function, but it has no disclosure checks. It could be potentially disclosive for small matrices.What's changed
Throw an error if the number of rows of the input matrix is <
nfilter.subsetHow to test