Uh oh!
There was an error while loading. Please reload this page.
feat: support remote Armadillo URLs via local_settings.csv - #664
Conversation
There was a problem hiding this comment.
I am wondering about lines 46-50, it appears to me ds.test_env$server_ip_address is just ip address, but is being assigned to a URL at line 49, so doesn't specify protocol or port of URL.
Have I missed something?
I think it was intended for remote host name to be placed in "local_settings.csv" if needs to be specified.
timcadman
commented
Apr 22, 2026
Maybe I've missed something! The issue I had was that it works fine if you specify localhost in the |
StuartWheater
commented
Apr 22, 2026
OK, but what if a port needs to be added to a hostname other than localhost. For example, if I the test server is http://datashield-big.home:8080/ What make is more complicated is that there is one test that needs a hostname not an url. (PS: Not sure why CSV was chooses, JSON would be more flexible) |
timcadman
commented
Apr 23, 2026
Good point - let me have a rethink and see if I can come up with a more flexible solution |
timcadman
commented
Apr 23, 2026
Latest go - specify full URL in |
StuartWheater
commented
Apr 24, 2026
OK, I will make the other code changes needed for that (Opal bit), check the wiki and run the re-tests. |
StuartWheater
commented
Apr 24, 2026
(PS: Default protocol for Opal is now http, so default port is also 8080) |
timcadman
commented
Apr 24, 2026
Ok thanks! |
StuartWheater
commented
Apr 24, 2026
CI Tests running:
Will add to PR if successful. |
Feat/armadillo remote url
StuartWheater
left a comment
There was a problem hiding this comment.
Passed tests and is clearer than original
Uh oh!
There was an error while loading. Please reload this page.
Background
Existing logic to construct armadillo url only works for localhost. To do performance testing we need to use a remote server to simualte real life conditions.
What's changed
If URL specified in
local_settingsis localhost it constructs url, for all other urls it uses as-is.How to test