Chore/githib actions ci

[timcadman]

Background

The existing Azure CI has worked well, but it can potentially be improved.

What's changed

• Migrated from Azure to github actions

New features

• Runs Opal and Armadillo each time
• Tests are run in parallel batches reducing time from >1 hour to <20 mins
• Added lint testing for code quality
• Add a summary of passes/fails in the comments

Still to do

• I have also tried to add code cov but I can't get it working - maybe we look at this together.

Testing

This was very AI generated flow, but I have asked it to review its own code and it assures me that none of the existing functionality is lost haha. I have also tested it against different combinations of passing and failing.

[github-actions]

❌ 3 of 5 checks failed

Check	Result
Devtools checks	✅ passed
Code quality	✅ 0 findings
Armadillo unit tests	❌ [ FAIL 10 | WARN 0 | SKIP 27 | PASS 11038 ]
Opal unit tests	❌ [ FAIL 6 | WARN 0 | SKIP 27 | PASS 11035 ]
Test coverage	❌ 61.2% vs 80% target

Tested against dsBase versions:
Armadillo: 7.0.0.9000
Opal: 7.0.0.9000

Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov

[StuartWheater]

Could we make version of dsBase being tested easily configured (done outside the action scripts), specification of profile being tested?

actions/setup-armadillo-with-dsbase/action.yml:

• I think, if like opal it used a prepared docker image for armadillo it would be easier to manage and others modify
• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.
• Line 63 not sure why it performs the same curl command twice

actions/setup-opal-with-dsbase/action.yaml‎

• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.

[StuartWheater]

Env var: PKG_INCLUDE_LINKINGTO - "This is sometimes useful"
(https://pak.r-lib.org/reference/pak-config.html)

[timcadman]

Thanks for your review Stuart. Before I merge it should we meet to discuss? E.g. I couldn't get codecov working but I've seen you have elsewhere? Do we replace Azure with this or do you first want to investigate CircleCI?

[timcadman]

Have tried to address all your comments:

• Use docker-compose for armadillo
• Use armadillo.install_pkg instead of curl commands
• Refactored to abstract out shared package setup used in both Armadillo and Opal

[timcadman]

Background

The existing Azure CI has worked well, but it can potentially be improved.

What's changed

• Migrated from Azure to github actions

New features

• Runs Opal and Armadillo each time
• Tests are run in parallel batches reducing time from >1 hour to <20 mins
• Added lint testing for code quality
• Add a summary of passes/fails in the comments

Still to do

• I have also tried to add code cov but I can't get it working - maybe we look at this together.

Testing

This was very AI generated flow, but I have asked it to review its own code and it assures me that none of the existing functionality is lost haha. I have also tested it against different combinations of passing and failing.

[github-actions]

❌ 3 of 5 checks failed

Check	Result
Devtools checks	✅ passed
Code quality	✅ 0 findings
Armadillo unit tests	❌ [ FAIL 10 | WARN 0 | SKIP 27 | PASS 11038 ]
Opal unit tests	❌ [ FAIL 6 | WARN 0 | SKIP 27 | PASS 11035 ]
Test coverage	❌ 61.2% vs 80% target

Tested against dsBase versions:
Armadillo: 7.0.0.9000
Opal: 7.0.0.9000

Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov

[StuartWheater]

Could we make version of dsBase being tested easily configured (done outside the action scripts), specification of profile being tested?

actions/setup-armadillo-with-dsbase/action.yml:

• I think, if like opal it used a prepared docker image for armadillo it would be easier to manage and others modify
• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.
• Line 63 not sure why it performs the same curl command twice

actions/setup-opal-with-dsbase/action.yaml‎

• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.

[StuartWheater]

Env var: PKG_INCLUDE_LINKINGTO - "This is sometimes useful"
(https://pak.r-lib.org/reference/pak-config.html)

[timcadman]

Thanks for your review Stuart. Before I merge it should we meet to discuss? E.g. I couldn't get codecov working but I've seen you have elsewhere? Do we replace Azure with this or do you first want to investigate CircleCI?

[timcadman]

Have tried to address all your comments:

• Use docker-compose for armadillo
• Use armadillo.install_pkg instead of curl commands
• Refactored to abstract out shared package setup used in both Armadillo and Opal

[timcadman]

Background

The existing Azure CI has worked well, but it can potentially be improved.

What's changed

• Migrated from Azure to github actions

New features

• Runs Opal and Armadillo each time
• Tests are run in parallel batches reducing time from >1 hour to <20 mins
• Added lint testing for code quality
• Add a summary of passes/fails in the comments

Still to do

• I have also tried to add code cov but I can't get it working - maybe we look at this together.

Testing

This was very AI generated flow, but I have asked it to review its own code and it assures me that none of the existing functionality is lost haha. I have also tested it against different combinations of passing and failing.

[github-actions]

❌ 3 of 5 checks failed

Check	Result
Devtools checks	✅ passed
Code quality	✅ 0 findings
Armadillo unit tests	❌ [ FAIL 10 | WARN 0 | SKIP 27 | PASS 11038 ]
Opal unit tests	❌ [ FAIL 6 | WARN 0 | SKIP 27 | PASS 11035 ]
Test coverage	❌ 61.2% vs 80% target

Tested against dsBase versions:
Armadillo: 7.0.0.9000
Opal: 7.0.0.9000

Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov

[StuartWheater]

Could we make version of dsBase being tested easily configured (done outside the action scripts), specification of profile being tested?

actions/setup-armadillo-with-dsbase/action.yml:

• I think, if like opal it used a prepared docker image for armadillo it would be easier to manage and others modify
• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.
• Line 63 not sure why it performs the same curl command twice

actions/setup-opal-with-dsbase/action.yaml‎

• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.

[StuartWheater]

Env var: PKG_INCLUDE_LINKINGTO - "This is sometimes useful"
(https://pak.r-lib.org/reference/pak-config.html)

[timcadman]

Thanks for your review Stuart. Before I merge it should we meet to discuss? E.g. I couldn't get codecov working but I've seen you have elsewhere? Do we replace Azure with this or do you first want to investigate CircleCI?

[timcadman]

Have tried to address all your comments:

• Use docker-compose for armadillo
• Use armadillo.install_pkg instead of curl commands
• Refactored to abstract out shared package setup used in both Armadillo and Opal

[timcadman]

Background

The existing Azure CI has worked well, but it can potentially be improved.

What's changed

• Migrated from Azure to github actions

New features

• Runs Opal and Armadillo each time
• Tests are run in parallel batches reducing time from >1 hour to <20 mins
• Added lint testing for code quality
• Add a summary of passes/fails in the comments

Still to do

• I have also tried to add code cov but I can't get it working - maybe we look at this together.

Testing

This was very AI generated flow, but I have asked it to review its own code and it assures me that none of the existing functionality is lost haha. I have also tested it against different combinations of passing and failing.

[github-actions]

❌ 3 of 5 checks failed

Check	Result
Devtools checks	✅ passed
Code quality	✅ 0 findings
Armadillo unit tests	❌ [ FAIL 10 | WARN 0 | SKIP 27 | PASS 11038 ]
Opal unit tests	❌ [ FAIL 6 | WARN 0 | SKIP 27 | PASS 11035 ]
Test coverage	❌ 61.2% vs 80% target

Tested against dsBase versions:
Armadillo: 7.0.0.9000
Opal: 7.0.0.9000

Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov

[StuartWheater]

Could we make version of dsBase being tested easily configured (done outside the action scripts), specification of profile being tested?

actions/setup-armadillo-with-dsbase/action.yml:

• I think, if like opal it used a prepared docker image for armadillo it would be easier to manage and others modify
• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.
• Line 63 not sure why it performs the same curl command twice

actions/setup-opal-with-dsbase/action.yaml‎

• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.

[StuartWheater]

Env var: PKG_INCLUDE_LINKINGTO - "This is sometimes useful"
(https://pak.r-lib.org/reference/pak-config.html)

[timcadman]

Thanks for your review Stuart. Before I merge it should we meet to discuss? E.g. I couldn't get codecov working but I've seen you have elsewhere? Do we replace Azure with this or do you first want to investigate CircleCI?

[timcadman]

Have tried to address all your comments:

• Use docker-compose for armadillo
• Use armadillo.install_pkg instead of curl commands
• Refactored to abstract out shared package setup used in both Armadillo and Opal

[timcadman]

Background

The existing Azure CI has worked well, but it can potentially be improved.

What's changed

• Migrated from Azure to github actions

New features

• Runs Opal and Armadillo each time
• Tests are run in parallel batches reducing time from >1 hour to <20 mins
• Added lint testing for code quality
• Add a summary of passes/fails in the comments

Still to do

• I have also tried to add code cov but I can't get it working - maybe we look at this together.

Testing

This was very AI generated flow, but I have asked it to review its own code and it assures me that none of the existing functionality is lost haha. I have also tested it against different combinations of passing and failing.

[github-actions]

❌ 3 of 5 checks failed

Check	Result
Devtools checks	✅ passed
Code quality	✅ 0 findings
Armadillo unit tests	❌ [ FAIL 10 | WARN 0 | SKIP 27 | PASS 11038 ]
Opal unit tests	❌ [ FAIL 6 | WARN 0 | SKIP 27 | PASS 11035 ]
Test coverage	❌ 61.2% vs 80% target

Tested against dsBase versions:
Armadillo: 7.0.0.9000
Opal: 7.0.0.9000

Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov

[StuartWheater]

Could we make version of dsBase being tested easily configured (done outside the action scripts), specification of profile being tested?

actions/setup-armadillo-with-dsbase/action.yml:

• I think, if like opal it used a prepared docker image for armadillo it would be easier to manage and others modify
• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.
• Line 63 not sure why it performs the same curl command twice

actions/setup-opal-with-dsbase/action.yaml‎

• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.

[StuartWheater]

Env var: PKG_INCLUDE_LINKINGTO - "This is sometimes useful"
(https://pak.r-lib.org/reference/pak-config.html)

[timcadman]

Thanks for your review Stuart. Before I merge it should we meet to discuss? E.g. I couldn't get codecov working but I've seen you have elsewhere? Do we replace Azure with this or do you first want to investigate CircleCI?

[timcadman]

Have tried to address all your comments:

• Use docker-compose for armadillo
• Use armadillo.install_pkg instead of curl commands
• Refactored to abstract out shared package setup used in both Armadillo and Opal

[timcadman]

Background

The existing Azure CI has worked well, but it can potentially be improved.

What's changed

• Migrated from Azure to github actions

New features

• Runs Opal and Armadillo each time
• Tests are run in parallel batches reducing time from >1 hour to <20 mins
• Added lint testing for code quality
• Add a summary of passes/fails in the comments

Still to do

• I have also tried to add code cov but I can't get it working - maybe we look at this together.

Testing

This was very AI generated flow, but I have asked it to review its own code and it assures me that none of the existing functionality is lost haha. I have also tested it against different combinations of passing and failing.

[github-actions]

❌ 3 of 5 checks failed

Check	Result
Devtools checks	✅ passed
Code quality	✅ 0 findings
Armadillo unit tests	❌ [ FAIL 10 | WARN 0 | SKIP 27 | PASS 11038 ]
Opal unit tests	❌ [ FAIL 6 | WARN 0 | SKIP 27 | PASS 11035 ]
Test coverage	❌ 61.2% vs 80% target

Tested against dsBase versions:
Armadillo: 7.0.0.9000
Opal: 7.0.0.9000

Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov

[StuartWheater]

Could we make version of dsBase being tested easily configured (done outside the action scripts), specification of profile being tested?

actions/setup-armadillo-with-dsbase/action.yml:

• I think, if like opal it used a prepared docker image for armadillo it would be easier to manage and others modify
• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.
• Line 63 not sure why it performs the same curl command twice

actions/setup-opal-with-dsbase/action.yaml‎

• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.

[StuartWheater]

Env var: PKG_INCLUDE_LINKINGTO - "This is sometimes useful"
(https://pak.r-lib.org/reference/pak-config.html)

[timcadman]

Thanks for your review Stuart. Before I merge it should we meet to discuss? E.g. I couldn't get codecov working but I've seen you have elsewhere? Do we replace Azure with this or do you first want to investigate CircleCI?

[timcadman]

Have tried to address all your comments:

• Use docker-compose for armadillo
• Use armadillo.install_pkg instead of curl commands
• Refactored to abstract out shared package setup used in both Armadillo and Opal

[timcadman]

Background

The existing Azure CI has worked well, but it can potentially be improved.

What's changed

• Migrated from Azure to github actions

New features

• Runs Opal and Armadillo each time
• Tests are run in parallel batches reducing time from >1 hour to <20 mins
• Added lint testing for code quality
• Add a summary of passes/fails in the comments

Still to do

• I have also tried to add code cov but I can't get it working - maybe we look at this together.

Testing

This was very AI generated flow, but I have asked it to review its own code and it assures me that none of the existing functionality is lost haha. I have also tested it against different combinations of passing and failing.

[github-actions]

❌ 3 of 5 checks failed

Check	Result
Devtools checks	✅ passed
Code quality	✅ 0 findings
Armadillo unit tests	❌ [ FAIL 10 | WARN 0 | SKIP 27 | PASS 11038 ]
Opal unit tests	❌ [ FAIL 6 | WARN 0 | SKIP 27 | PASS 11035 ]
Test coverage	❌ 61.2% vs 80% target

Tested against dsBase versions:
Armadillo: 7.0.0.9000
Opal: 7.0.0.9000

Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov

[StuartWheater]

Could we make version of dsBase being tested easily configured (done outside the action scripts), specification of profile being tested?

actions/setup-armadillo-with-dsbase/action.yml:

• I think, if like opal it used a prepared docker image for armadillo it would be easier to manage and others modify
• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.
• Line 63 not sure why it performs the same curl command twice

actions/setup-opal-with-dsbase/action.yaml‎

• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.

[StuartWheater]

Env var: PKG_INCLUDE_LINKINGTO - "This is sometimes useful"
(https://pak.r-lib.org/reference/pak-config.html)

[timcadman]

Thanks for your review Stuart. Before I merge it should we meet to discuss? E.g. I couldn't get codecov working but I've seen you have elsewhere? Do we replace Azure with this or do you first want to investigate CircleCI?

[timcadman]

Have tried to address all your comments:

• Use docker-compose for armadillo
• Use armadillo.install_pkg instead of curl commands
• Refactored to abstract out shared package setup used in both Armadillo and Opal

[timcadman]

Background

The existing Azure CI has worked well, but it can potentially be improved.

What's changed

• Migrated from Azure to github actions

New features

• Runs Opal and Armadillo each time
• Tests are run in parallel batches reducing time from >1 hour to <20 mins
• Added lint testing for code quality
• Add a summary of passes/fails in the comments

Still to do

• I have also tried to add code cov but I can't get it working - maybe we look at this together.

Testing

This was very AI generated flow, but I have asked it to review its own code and it assures me that none of the existing functionality is lost haha. I have also tested it against different combinations of passing and failing.

[github-actions]

❌ 3 of 5 checks failed

Check	Result
Devtools checks	✅ passed
Code quality	✅ 0 findings
Armadillo unit tests	❌ [ FAIL 10 | WARN 0 | SKIP 27 | PASS 11038 ]
Opal unit tests	❌ [ FAIL 6 | WARN 0 | SKIP 27 | PASS 11035 ]
Test coverage	❌ 61.2% vs 80% target

Tested against dsBase versions:
Armadillo: 7.0.0.9000
Opal: 7.0.0.9000

Logs: Devtools checks · Code quality · Armadillo unit tests · Opal unit tests · Codecov

[StuartWheater]

Could we make version of dsBase being tested easily configured (done outside the action scripts), specification of profile being tested?

actions/setup-armadillo-with-dsbase/action.yml:

• I think, if like opal it used a prepared docker image for armadillo it would be easier to manage and others modify
• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.
• Line 63 not sure why it performs the same curl command twice

actions/setup-opal-with-dsbase/action.yaml‎

• Does image requires "Uninstall default MySQL"? I would expect that to be specific to Azure Pipeline images.

[StuartWheater]

Env var: PKG_INCLUDE_LINKINGTO - "This is sometimes useful"
(https://pak.r-lib.org/reference/pak-config.html)

[timcadman]

Thanks for your review Stuart. Before I merge it should we meet to discuss? E.g. I couldn't get codecov working but I've seen you have elsewhere? Do we replace Azure with this or do you first want to investigate CircleCI?

[timcadman]

Have tried to address all your comments:

• Use docker-compose for armadillo
• Use armadillo.install_pkg instead of curl commands
• Refactored to abstract out shared package setup used in both Armadillo and Opal