Skip to content

feat: Added fast hot patch for getColumn - #3

Merged
puehringer merged 2 commits into
mh/add_row_model_middlewarefrom
mh/sort_performance
Jun 15, 2026
Merged

feat: Added fast hot patch for getColumn#3
puehringer merged 2 commits into
mh/add_row_model_middlewarefrom
mh/sort_performance

Conversation

@dvmoritzschoefl

Copy link
Copy Markdown

Problem:

  • Memo chain in getColumn caused sorts to take roughly 15 seconds
  • This simple change improves it to 3 seconds

Further:

The sorting function is actually very bad and can improved a lot (maybe in v9?). Just as an example:

image

calls the value getters again. mabye a "pre sort" value cache would be an option?

Comment threadpackages/table-core/src/core/table.ts Outdated
@puehringer
puehringer merged commit 339501f into mh/add_row_model_middlewareJun 15, 2026
@puehringer
puehringer deleted the mh/sort_performance branch June 15, 2026 07:22
puehringer pushed a commit that referenced this pull request Jun 15, 2026
* Added middleware functions
* Added .flat() to getUniqueValues implementation
* feat: Added fast hot patch for getColumn (#3)
* Added fast path to row getValue
* Used internal implementation
@dvmoritzschoefldvmoritzschoefl changed the title feat: Added fast hot patch for getColumn(PACK THIS)feat: Added fast hot patch for getColumnJun 15, 2026
@puehringerpuehringer changed the title (PACK THIS)feat: Added fast hot patch for getColumnfeat: Added fast hot patch for getColumnJun 15, 2026
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

@dvmoritzschoefl@puehringer