Skip to content

Hand back findings and release 8.1.0 inspect surveys without reset - #28

Merged
cursor[bot] merged 7 commits into
mainfrom
cursor/review-workflow-plan-3073
Aug 19, 2026
Merged

Hand back findings and release 8.1.0 inspect surveys without reset#28
cursor[bot] merged 7 commits into
mainfrom
cursor/review-workflow-plan-3073

Conversation

@vriesd

@vriesdvriesd commented Aug 19, 2026•
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

A /flow-auto codebase review on 8.0.0 was too thorough, stalled on blockers, and never handed back a findings list. That is the change-lifecycle model, not a missed prompt.

This PR implements phases 1 to 9 of .agents/plans/01-review-workflow/ and prepares 8.1.0. Merging to main creates v8.1.0, the GitHub release from the changelog notes, and the npm publish. The tag is not pushed from this branch, because that would release before merge.

What landed

  • Derived digest.findingsDigest(session) walks every identified finding across attempts. A later pass that omits a prior id keeps the row with live: false. Nothing is persisted. Closure is not required.
  • Compact status. The view /flow-auto actually reads always includes findingsDigest. Empty is [], never a missing key.
  • Close delivery. The same digest is on DeliveryProjection. formatReport lists live rows, then historical ones, so a completed retry cannot print only terminal findings: none when blockers existed.
  • Handback paste.flow-run blocked review, the manager kernel, and recovery print compact findingsDigest when Flow hands control back.
  • Auto-drive. A blocked, flow_feature_reset, or dispatch-flow-reviewer idle sends one conversational prompt to print the digest, then parks or stops. Mechanical continuation is still only flow_run_start and flow_session_close. ADR 0008 records that extra prompt.
  • Reviewer budget. Continue a concurrency or state-machine matrix after one blocker only when the packet's riskLenses is non-empty or its summary includes a matrix. adjacent-defect-refused is unchanged.
  • Inspect planning. Inspect-only goals (review, audit, survey, no promised edit) invent no repair features. Save them with kind: "inspect".
  • Inspect kind. Optional PlanFeature.kind is change or inspect. Absent hydrates to change, so existing Session v5 documents keep the repair loop. A failed inspect review completes that slice. The next feature can start without flow_feature_reset. Session completed then means the survey finished, not that the tree is clean. Repair stays a later change feature. ADR 0005 records the rule.
  • Eval. Ungated inspect-goal-delivers-findings fails when final text, close delivery, and compact digest all omit a planted interval defect.

Does not restore the v6 audit ledger. Does not add a persisted intent classifier.

Verification

  • bun run check
  • bun run replay (9/9, including adjacent-defect-refused)
  • Focused unit tests for digest, compact, delivery, auto-drive, prompt structure, inspect complete-with-blockers, and the new scenario grader
  • bun run release:metadata matches 8.1.0
Open in WebOpen in Cursor

cursoragentand others added 4 commits August 19, 2026 16:45
@cursoragent@vriesd
Plan a derived findings digest for /flow-auto review UX.
8a293f7
Codebase-review goals currently invent a change DAG, stall on the first
blocker, and only emit a findings list after close. This plan derives a
digest from existing runs, shows it at every handback, and defers an
inspect kind until evals show the first eight phases still leak.
Co-authored-by: vriesd <vriesd@users.noreply.github.com>
@cursoragent@vriesd
Derive a findings digest on compact status and close delivery.
f8d2e89
Walk every identified finding across attempts so a later passing review
cannot erase historical blockers. Compact always carries the list; close
delivery prints live rows then historical ones.
Co-authored-by: vriesd <vriesd@users.noreply.github.com>
@cursoragent@vriesd
Prompt one /flow-auto handback when a blocked run would go silent.
f8ad66a
A blocked, reset, or pending-reviewer idle now sends one conversational
prompt to print compact findingsDigest. Mechanical continuation stays
start and close only; a second idle at the same revision does not loop.
Co-authored-by: vriesd <vriesd@users.noreply.github.com>
@cursoragent@vriesd
Paste findings at handback and measure inspect-only review.
7fbe4a7
Manager and run skills print compact findingsDigest at a checkpoint.
Reviewers finish a concurrency matrix only when the packet asked for one.
Inspect-only plans invent no repair features. A new ungated eval fails
when /flow-auto on a planted inspect goal leaves no user-visible list.
Co-authored-by: vriesd <vriesd@users.noreply.github.com>
@cursorcursorBot changed the title Plan: derived findings digest for /flow-auto review UXHand back a findings digest from compact status and /flow-autoAug 19, 2026
cursoragentand others added 2 commits August 19, 2026 17:45
@cursoragent@vriesd
Complete inspect features with blockers so later slices start without…
69c8c89
… reset.
Optional PlanFeature.kind hydrates absent to change. A failed inspect review
finishes that survey slice, so the next feature can start without reset.
Co-authored-by: vriesd <vriesd@users.noreply.github.com>
@cursoragent@vriesd
Expose optional PlanFeature.kind on the OpenCode plan-save schema.
8c15fce
The host schema is a separate zod tree from the application schema. Without
this field the host rejected inspect plans the runtime already accepted.
Co-authored-by: vriesd <vriesd@users.noreply.github.com>
@cursorcursorBot changed the title Hand back a findings digest from compact status and /flow-autoHand back findings and complete inspect surveys without resetAug 19, 2026
@cursoragent@vriesd
Prepare 8.1.0 so merge to main cuts the release.
791b962
Bump the package and install pins, and write dated notes. An untagged
package version on main creates v8.1.0 and publishes. Pushing that tag
from this PR would release before merge.
Co-authored-by: vriesd <vriesd@users.noreply.github.com>
@cursorcursorBot changed the title Hand back findings and complete inspect surveys without resetHand back findings and release 8.1.0 inspect surveys without resetAug 19, 2026
@cursor
cursorBot merged commit fbf8b73 into mainAug 19, 2026
6 checks passed
@vriesd
vriesd deleted the cursor/review-workflow-plan-3073 branch August 19, 2026 21:53
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@vriesd@cursoragent