feat(workspace): add local profile persistence - #51
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes#50
status:approvedlabel.Pull request type
Select exactly one option and apply the matching
type:*label.type:bug)type:feature)type:docs)type:refactor)type:chore)type:breaking-change)Summary
splice-core, with database-wide session ownership and no UI changes.review-324152ec577a72ab, candidatec9f6cb71f847a8f40db543e2c74b0b3fdb742c59.Changes
crates/splice-core/src/workspace.rscrates/splice-core/tests/workspace_store.rscrates/splice-core/src/lib.rscrates/splice-core/Cargo.toml,Cargo.lockTest plan
cargo test -p splice-core --test workspace_store(9 passed), plus 20 repeated concurrent-save runs (all passed).splice-coretests passed; Clippy passed with-D warnings; rustfmt and whitespace checks passed;cargo check -p splice-core --target x86_64-pc-windows-gnupassed.Chained pull request context
workspace.rspersistence invariants, then the matchingworkspace_store.rsintegrity and concurrency regressions.Chain overview
Review budget and size exception
size:exception: database-wide session uniqueness, invalid-data quarantine/default/backup recovery, portable repeated-save rotation, and deterministic concurrent-save coverage are one inseparable data-integrity boundary. Splitting them would permit an unsafe persistence implementation to land without the tests that prove its rollback and corruption behavior.origin/masterat8f8bdf8467e8da6241ef08d72f2a0743e6ddb30e.Concurrency and rollback
fs2lock outside database rotation serializes the complete read-modify-write transaction; 20 deterministic repetitions passed.e2e60fbto remove only the workspace module, its tests/export, and itsserde_json,tempfile, andfs2dependency entries; no unrelated behavior is coupled to this unit.Informational warnings
These are non-blocking review INFO findings. There are no critical findings or unresolved blockers.
Contributor checklist
Closes,Fixes, orResolves.type:*label.Co-Authored-Bytrailers.