Uh oh!
There was an error while loading. Please reload this page.
multi: Add 12 and 24 word seed restoration. - #33
Merged
Conversation
JoeGruffins
commented
Oct 21, 2025
Uh oh!
There was an error while loading. Please reload this page.
JoeGruffins
commented
Oct 21, 2025
Uh oh!
There was an error while loading. Please reload this page.
JoeGruffins
commented
Oct 23, 2025
MemberAuthor
Allowing for different length mnemonics and add more tests https://github.com/decred/libwallet/compare/07ce00bf6fe9e3378a8b41d69f176b9397e46a77..bf9985b286b73e4a6478cb994a9ab4e34dcb1a20 |
JoeGruffins
commented
Oct 23, 2025
| switch nWords { | ||
| case 15: | ||
| seed, birthday, err = dexmnemonic.DecodeMnemonic(cfg.Mnemonic) | ||
| seedType = dcr.STFifteenWords |
MemberAuthor
There was a problem hiding this comment.
Maybe doesn't even need the type... If this is how we tell in the beginning, can just always do this I guess
MemberAuthor
There was a problem hiding this comment.
Leaving the type for now. I guess could have more types in the future that are the same length as current. This also reads better later.
jrick
approved these changes
Oct 23, 2025
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes#32