Skip to content

fix: TCP reassembled packets being mistakenly identified as retransmi… - #11909

Merged
yuanchaoa merged 1 commit into
mainfrom
fix-tcp-reassembled-as-retrans
Sep 21, 2026
Merged

yuanchaoa merged 1 commit into
mainfrom
fix-tcp-reassembled-as-retrans

Conversation

@yuanchaoa

Copy link
Copy Markdown
Contributor

…ssions

This PR is for:

  • Agent

fix: TCP reassembled packets being mistakenly identified as retransmi…

Steps to reproduce the bug

Changes to fix the bug

  • 连续3个包,长度都是100,如果1和2聚合在tcp重传中会创建1-200的记录
  • 后面2和3聚合为100-300和上次记录有重叠判定为重传
  • 修改为添加 raw_payload_len单独用作重传的判定

Affected branches

  • main

Checklist

  • Added unit test to verify the fix.
  • Verified eBPF program runs successfully on linux 4.14.x.
  • Verified eBPF program runs successfully on linux 4.19.x.
  • Verified eBPF program runs successfully on linux 5.2.x.

@yuanchaoa

Copy link
Copy Markdown
Contributor Author

@codex review一下这个提交 回复用中文

@yuanchaoa

Copy link
Copy Markdown
Contributor Author

@claude review一下这个提交 回复用中文

@claude

claude Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error after 2m 52s —— View job


I'll analyze this and get back to you.

@yuanchaoa
yuanchaoa force-pushed the fix-tcp-reassembled-as-retrans branch from 0f6fdbf to 42b57f1 Compare September 21, 2026 07:48
@yuanchaoa

Copy link
Copy Markdown
Contributor Author

@claude review一下这个提交 回复用中文

@claude

claude Bot commented Sep 21, 2026

Copy link
Copy Markdown
Contributor

Claude encountered an error after 8m 42s —— View job


正在审查 PR 修改

  • 读取 PR diff 与相关代码
  • 分析改动逻辑
  • 提交审查意见

@yuanchaoa
yuanchaoa force-pushed the fix-tcp-reassembled-as-retrans branch 2 times, most recently from 6d9e6c0 to f1287ef Compare September 21, 2026 08:20
Comment thread agent/src/common/meta_packet.rs Outdated
…ssions

* 连续3个包,长度都是100,如果1和2聚合在tcp重传中会创建1-200的记录
* 后面2和3聚合为100-300和上次记录有重叠判定为重传
* 修改为添加 raw_payload_len单独用作重传的判定
@yuanchaoa
yuanchaoa force-pushed the fix-tcp-reassembled-as-retrans branch from f1287ef to 2380594 Compare September 21, 2026 08:35
@yuanchaoa
yuanchaoa enabled auto-merge (rebase) September 21, 2026 08:40
@yuanchaoa
yuanchaoa merged commit 9a1219f into main Sep 21, 2026
9 checks passed
@yuanchaoa
yuanchaoa deleted the fix-tcp-reassembled-as-retrans branch September 21, 2026 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants