One embedding refresh per base at a time - #295
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: Wayland Yang <wayland0916@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #282.
Creating a base with three packs enqueues three
embed_ontologyjobs. With worker concurrency at 64 they ran at the same time, each read the same set of terms still missing a vector, and each embedded all of them: 3,752 terms embedded three times in the report on #282.Refreshes for one base now take turns. A per-base
tokio::sync::Mutex(in a process-wide table) is held for the duration ofrefresh_scoped; a job that arrives while another is running waits, then re-reads the missing set, which by then is empty or holds only the terms added after the first job read its set. Waiting rather than skipping means nothing is left for a later refresh to pick up. Different bases are unaffected.A unit test pins the behaviour: two refreshes of one base serialise, another base is not blocked.
cargo fmt,cargo clippy -D warnings,cargo test -p utopia-server ontology_indexpass.🤖 Generated with Claude Code