Classes, properties, attributes and knowledge edit in dialogs; the panel shows - #480
Merged
Merged
Conversation
…nel shows Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
…e kind fans out Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
Contributor
Author
|
Round 2, from looking at 5198:
|
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
…ource count Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
Contributor
Author
|
Round 3 — the entity panel's Relations, after the question "how do others do it":
|
… page Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
Contributor
Author
|
Round 4: the entity panel's rows follow the Ontology page's Relations exactly — no predicate sub-groups. Under From ⟨entity⟩ / To ⟨entity⟩ each fact is one row: the direction arrow in the icon slot, the relation name on the left (with disputed / % / unconfirmed after it), the interval and the other entity's name on the right; the whole row navigates. Hover still reveals "N sources" and the pencil; facts that no longer hold fold under "N past" at the section's tail. |
This was referenced Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The right-hand panels on Ontology and Graph now only show; every change opens a dedicated dialog.
What changes
FormDialog(ui/dialog.tsx): one shell for edit dialogs — title, optional description, the body in a<form>(Enter in a field saves; the selects already swallow their own Enter), Cancel and Save at the bottom right, an optional Delete on its own at the bottom left. Always mounted, conditionally rendered, likeDangerConfirm.pages/ontologyDialogs.tsx):ClassDialog,PropertyDialog(wide),AttributeDialog,ConnectDialog. The three inline forms (ClassForm,PropertyForm,AttributeForm) and the connect widget leaveOntology.tsx; the fields are unchanged. The docked panel gets anactionsslot (a pencil beside the close key) and shows read-only definitions: parent, disjoint, description for a class; subject, object, temporal semantics, the axioms that are on, inverse, super-property, description for a property. Attribute rows open the dialog; "New attribute", "Connect an existing relationship…", "New relationship…" and the rail's "New class / New property" open dialogs too; "New sub-class" sits under the definition.Selloses itsnew-class/new-relationstates — creation no longer docks a form.pages/graphDialogs.tsx):EntityDialog(name + type, replacing the inline block under the panel header) andFactTimeDialog(start, end as three radios, why — replacing the editor that unfolded inside a timeline row).DESIGN.mdrule 6 gains the sentence: a floating panel shows; it does not edit.ontology.edit/editClass/editProperty/editAttribute/connectTitle/connectOpen/noDescription/axiomsNone,graph.editTitle,newSubClassretitled (it carries a Plus icon now), en and zh.Verified
tsc, style guard clean.🤖 Generated with Claude Code