A rule's criterion is a column, not a sentence - #490
Merged
Merged
Conversation
Signed-off-by: WaylandYang <wayland0916@gmail.com>
WaylandYang
force-pushed
the
feat/a-criterion-reads-as-a-block
branch
from
September 9, 2026 02:13
21e304e to
dbc148a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The criterion was a run of prose in the rule's name cell —
Person where Years of service is at least 10 and Clearance is one of secret, top-secret or Years of service is at least 25. Two problems, and the second one gets worse from here:andandorcarry the same weight, soA and B or Cdoes not say which binds tighter. The one thing a reader must not get wrong about a rule is exactly this.The criterion is now its own column, one condition per line:
Stacked lines are the conjunction — a column of conditions reads as "all of these" the way every filter list does, so no connective is printed for it.
oris the only word left, in its own gutter at the head of each block after the first, because it is the only one that carries information: a second block is another way to satisfy the criterion, not another requirement (0029).The subject class moves to
Person → Veteranin Concludes, where it belongs: a rule says "a Person like this is a Veteran", and the subject is the left half of that sentence rather than part of the criterion. That frees the rule cell to be a name and its description.A one-condition rule is still one line. Rows grow only with conditions, which are the content.
🤖 Generated with Claude Code