KB members read like the deployment's user list - #492
Merged
Merged
Conversation
Signed-off-by: WaylandYang <wayland0916@gmail.com>
WaylandYang
force-pushed
the
feat/kb-members-like-the-admin-list
branch
from
September 9, 2026 02:00
d1ebf23 to
f3cbf60
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The members section was a
SettingsCard— a list of rows with Add member in the card's footer and no way to filter. A settings card's border earns its keep by answering "what does this Save send?", and there is no Save here: every change applies immediately. So the border was doing list-container duty while the one control that acts on the list sat inside it.It now reads like the deployment's user list (#469), which is what a knowledge base's member list should have looked like all along:
The hint about
openbases having no viewer role to grant moves above the toolbar, where it still reads before the list.🤖 Generated with Claude Code