Skip to content

KB members read like the deployment's user list - #492

Merged
WaylandYang merged 1 commit into
devfrom
feat/kb-members-like-the-admin-list
Sep 9, 2026
Merged

WaylandYang merged 1 commit into
devfrom
feat/kb-members-like-the-admin-list

Conversation

@WaylandYang

Copy link
Copy Markdown
Contributor

The members section was a SettingsCard — a list of rows with Add member in the card's footer and no way to filter. A settings card's border earns its keep by answering "what does this Save send?", and there is no Save here: every change applies immediately. So the border was doing list-container duty while the one control that acts on the list sat inside it.

It now reads like the deployment's user list (#469), which is what a knowledge base's member list should have looked like all along:

  • The search box and the role filter sit outside the table, on the left of a toolbar row, with Add member at the right end of the same row. When a filter empties the list, the way to change the filter does not go with it (DESIGN.md 6).
  • The list is a table — User / Role / Remove — with fixed columns, so the role and the action stop drifting with the length of a name.
  • The role is static text until you click it, then a dropdown. A column of dropdowns makes a read-only list look like a form waiting to be filled in, and changing someone's role is an occasional act.
  • An empty list and an emptied filter say different things: one sends you to Add member, the other to the filter.

The hint about open bases having no viewer role to grant moves above the toolbar, where it still reads before the list.

🤖 Generated with Claude Code

Signed-off-by: WaylandYang <wayland0916@gmail.com>
@WaylandYang
WaylandYang force-pushed the feat/kb-members-like-the-admin-list branch from d1ebf23 to f3cbf60 Compare September 9, 2026 02:00
@WaylandYang
WaylandYang merged commit f97eecd into dev Sep 9, 2026
4 checks passed
@WaylandYang
WaylandYang deleted the feat/kb-members-like-the-admin-list branch September 9, 2026 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant