Skip to content

A floating panel does not borrow the colour behind it - #525

Merged
WaylandYang merged 4 commits into
devfrom
fix/chrome-has-no-hue
Sep 9, 2026
Merged

WaylandYang merged 4 commits into
devfrom
fix/chrome-has-no-hue

Conversation

@WaylandYang

Copy link
Copy Markdown
Contributor

The chrome had a hue. Nobody chose it.

backdrop-filter: blur() passes the colours behind it straight through, so every
glass surface in the app was tinted by whatever it happened to be floating over —
and on the graph page that is a field of saturated type colours. The right panel
came out faintly blue. It was never a token; it was the canvas leaking upward.

Three changes:

  • saturate(0.3) on every backdrop (.glass, .glass-strong, .u-menu-glass,
    .u-pill). Blur alone keeps the chroma and only smears it. Draining the
    saturation leaves the luminance — panels still read as translucent, still darken
    over bright content, and are grey while doing it.
  • --u-surface-strong 0.72 → 0.68. Slightly more of what is behind, now that
    what comes through is neutral.
  • The class legend opens like every other panel. It was a bespoke popover with
    its own header and a close button. It now uses the knowledge-base switcher's
    anatomy — title, rule, body — and gains the two rows that were missing: Show all
    and Hide all. A switched-off class is struck through rather than only dimmed;
    dimming alone reads as "disabled", not "I turned this off".

Checked

  • pnpm build clean; style guard 45/45.
  • Looked at on the graph page over a dense canvas, which is where the tint was
    visible in the first place.

Stacked

On top of #506. Review that first.

🤖 Generated with Claude Code

@WaylandYang
WaylandYang force-pushed the fix/a-fact-row-says-which-fact branch from f6e3d71 to 2897e0d Compare September 9, 2026 02:51
Base automatically changed from fix/a-fact-row-says-which-fact to dev September 9, 2026 02:57
WaylandYang and others added 4 commits September 9, 2026 10:57
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: WaylandYang <wayland0916@gmail.com>
(cherry picked from commit 8b3a6cd5f83532e9da405851829c5b3133191631)
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: WaylandYang <wayland0916@gmail.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: WaylandYang <wayland0916@gmail.com>
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: WaylandYang <wayland0916@gmail.com>
@WaylandYang
WaylandYang force-pushed the fix/chrome-has-no-hue branch from b22711c to d55a3fd Compare September 9, 2026 02:58
@WaylandYang
WaylandYang merged commit a4d210f into dev Sep 9, 2026
4 checks passed
@WaylandYang
WaylandYang deleted the fix/chrome-has-no-hue branch September 9, 2026 03:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant