The LLM client's literals read at the point of use, and its test servers answer politely - #542
Merged
Merged
Conversation
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
This was referenced Sep 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #538, no behaviour change in the client.
"LLM","Embedding"and"unknown error"in the client, and the twenty test fixtures ("hi","user","502 Bad Gateway","界", the number one). A name earns its place when the value means something beyond itself or has to stay in step across sites; none of these did, and in a test the literal is the documentation.MAX_ERROR_DETAIL_CHARSkeeps its name and gains the reason for 500 and for counting characters.response_failureanderr_detailget doc comments in this repository's voice: what changed, the LM Studio 400 that motivated it, and why a body that cannot be read is stillUnreachable.Unreachabledoc sentence reads in one breath.Content-Length) before writing their answer and shut down cleanly. Written as they were, they closed the socket with the request unread; Windows answers that with RST and the client sees "connection aborted" (os error 10053) instead of the response, so two of the six tests failed on a Windows checkout while passing on the Linux CI. Same behaviour under test, now the same on both.cargo test -p utopia-llmpasses, three runs in a row on Windows.🤖 Generated with Claude Code