The chat rail has one column - #607
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The conversation rail had three left edges in one narrow column: the empty-state line
started at 16, "Recent" and every conversation title at 20, and the search placeholder and
"New chat" at 42.
The rail baseline is box 8 / icon 20 / text 42 (DESIGN rule 2): the rail pads 8, a nav row
pads 12, the icon is 14 wide and sits 8 from its label, and a medium input with an icon
carries the same
left-3/pl-[34px]. A nav row with no icon keeps the slot so its labellands on that same line, and
flushis the opt-out for a rail where no row has an icon atall. This rail has one row with an icon, "New chat", so nothing in it should have been
flush. It was the only place in the app using the flag.
"Recent" and the conversation titles drop
flushand return to 42. The empty state getspl-[34px]instead ofpx-2, which puts it on the same line as the titles it stands infor rather than on a third one of its own. The comment that argued for flush is replaced
by the baseline itself; its point was that a column of repeated bubble icons would push
every title right, which is true and is why the slot stays empty instead of being filled.