The design rules speak shadcn - #632
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
web/DESIGN.mdwas written before the interface moved onto shadcn (#622), and several things it stated as fact had stopped being true. It is the spec contributors read before touching the web code, so a wrong sentence in it gets copied.Corrected
--radius(10 px): cell ×0.8, control ×1, overlay ×1, panel ×1.4. That makes an overlay flatter than a panel, so the old line "a panel inside an overlay steps inwards" would now be false. The rule is restated as it actually holds: a panel does not go inside an overlay, which rule 6 already implies.--u-*(dark in:root, light in:root[data-theme="light"]) and shadcn's (light in:root, dark in.dark).theme.tssets bothdata-themeand.dark, so registry components follow the theme unedited.opacity-50, notopacity-40.shadcn addand never edited.VENDORexemption forsrc/components/ui/.Added — rules settled in the last few days that were only in code
Status);Chipis for things that are not states.Table/Th/Td), not stacked name-and-chips rows.REVEAL) and opens a menu or aFormDialog, not standing text on every row.w-64. A count in a label goes in parentheses:Pending (3).CARD_ACTIONS: bottom-left, wrapping, destructive action last. What explains the card goes above its content.FormDialogcan carry several destructive actions when they differ in weight.#ffffffas#fffandrgba(…)as#rrggbbaa. A reader that only knows six-digit hex falls back to grey without a word.Each of these was checked against the code on
devbefore it was written down: the token names, the radius multipliers, the--u-fast/--u-basedurations, the exported component names, and the guard's exemption. Everything else in the document still holds and is unchanged.🤖 Generated with Claude Code