A fact row points at its edge - #653
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
WaylandYang
force-pushed
the
feat/a-fact-row-points-at-its-edge
branch
from
September 13, 2026 11:32
d128ce1 to
b9ab10f
Compare
WaylandYang
marked this pull request as ready for review
September 13, 2026 15:34
Contributor
Author
|
Looked at in the browser on a local base (Anthropic, 124 facts):
No console errors from the interaction. One follow-up, not blocking: in a narrow window the framing does not account for the side panel, so one endpoint can sit behind it. 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Clicking a fact in the entity panel used to jump straight to the other entity. There was no way to see which of the selected entity's edges a row was talking about: once an entity is selected, all of its edges light up equally.
A fact row now carries two separate targets.
Edges are matched by fact id, which is already the edge key on the canvas. When the fact's edge is not on the canvas, for example because the timeline filters it out, nothing substitutes for it, and a click falls back to navigating to the object. Literal-value facts have no edge and no canvas action.
The per-word hover style lives in
ui/index.tsxasPOINT_WORD, because pages may not write hover classes.Verified:
pnpm buildpasses, including the style guard and tsc, and the vitest suite passes. I could not sign in to the preview from the agent, so the interaction still needs a look in the browser.🤖 Generated with Claude Code