Blocked-derivations list follows the recording axis (#307) - #676
Merged
WaylandYang merged 3 commits intoSep 13, 2026
Merged
Conversation
The entity panel's 'blocked' key is asked alongside derived, facts, and same_name, all of which already carry as_of through entity_detail. blocked_for_entity hard-coded 'v.status = ''open''', so a violation detected in March and closed in April still haunted the rewound panel. Wire as_of through blocked_for_entity and the entity panel callsite. violation_open_at is the same shape as derived_held_at / facts_held_at, with a different clock (detected_at / decided_at). Write paths (decide_violation, retract_from_violation, etc.) keep the existing status filter — 0019. Test (DB-backed, UTOPIA_DATABASE_URL-gated): - still_open: detected 3 月, never resolved - resolved: detected 3 月 20, resolved 4 月 15 回看 Mira 的 blocked: - 当下:still_open 一条 - 2 月:都未检出 → 0 条 - 3 月 25 日:resolved 在 decided_at 之前还开着 → 2 条 - 5 月:resolved 在 decided_at 之后消失 → still_open 一条 The two violations cross over between 3 月 25 日 and 5 月 — without as_of the same two rows always return just still_open today. cargo check -p utopia-store -p utopia-server clean. cargo fmt clean. cargo clippy -p utopia-store -p utopia-server --all-targets -- -D warnings clean. cargo test -p utopia-store --test blocked_for_entity_respects_as_of passes; the existing a_contradiction_points_upstream test still passes after passing None to the new signature. Signed-off-by: Royce <roycelam@umich.edu> Co-authored-by: Claude Opus 5 <noreply@anthropic.com>
Signed-off-by: WaylandYang <wayland0916@gmail.com> # Conflicts: # crates/utopia-server/src/api/graph_routes.rs
Contributor
|
@rollroyces thanks. Merged current 🤖 Generated with Claude Code |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #307, partial.
The entity panel's
blockedkey is asked alongsidederived,facts, andsame_name, all of which already carryas_ofthroughentity_detail.blocked_for_entityhard-codedv.status = 'open', so a violation detected in March and closed in April still haunted the rewound panel.Wire
as_ofthroughblocked_for_entityand the entity panel callsite.violation_open_atis the same shape asderived_held_at/facts_held_at, with a different clock (detected_at/decided_at). Write paths (decide_violation,retract_from_violation, etc.) keep the existingstatusfilter — per 0019.Test (DB-backed,
UTOPIA_DATABASE_URL-gated):still_open: detected 3 月, never resolvedresolved: detected 3 月 20, resolved 4 月 15回看 Mira 的 blocked:
still_open一条resolved在decided_at之前还开着 → 2 条resolved在decided_at之后消失 →still_open一条The two violations cross over between 3 月 25 日 and 5 月 — without
as_ofthe same two rows always return juststill_opentoday.cargo check -p utopia-store -p utopia-serverclean.cargo fmtclean.cargo clippy -p utopia-store -p utopia-server --all-targets -- -D warningsclean.cargo test -p utopia-store --test blocked_for_entity_respects_as_ofpasses; the existinga_contradiction_points_upstreamtest still passes after passingNoneto the new signature.Signed-off-by: Royce roycelam@umich.edu
Co-authored-by: Claude Opus 5 noreply@anthropic.com