Trino has no key views, and the comment says so - #687
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment-only change. The note in
trino::schema_rowsaid Trino and Snowflake expose PK/FK throughinformation_schema.table_constraints/key_column_usage, and that Databricks' Unity Catalog records no primary keys. All three are wrong, and the first one led to #682, which queried views that don't exist.information_schemacomes from a built-in connector with onlycolumns,tables,views,schemata,table_privilegesand the role tables. The constraint views resolve to TABLE_NOT_FOUND.key_column_usage. Column-level keys come fromSHOW PRIMARY KEYS/SHOW IMPORTED KEYS.table_constraints/key_column_usage/referential_constraints.The
SchemaColumn.is_primary_keydoc now also names the engines that read keys: Postgres (#671) and MySQL/MariaDB (#678).🤖 Generated with Claude Code