An entity panel lists the entity's names - #711
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Signed-off-by: WaylandYang <wayland0916@gmail.com>
Contributor
Author
|
Looked at it in the browser on the identity bench base (东海海洋研究所, 4 names): the Names section lists the shown name first, then the others with source counts, and Remove appears on hover for every name except the shown one. No console errors beyond the login redirect. Worth noting what it surfaced: 澜海研究院财务部 and 澜海研究院理事会 are recorded as names of 东海海洋研究所. Those are sub-organisations, the kind of wrong alias this panel exists to catch. The known issue that a rename merge keeps the old canonical name is on the server side ( 🤖 Generated with Claude Code |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The entity panel shows an entity's names, and a wrong one can be removed.
Why
Since #670 (0041) every name an entity carries is a
known_asfact, andGET /kbs/{id}/entities/{entity}returns them undernames: the shown name, abbreviations and former names, each with sources and validity. The panel never rendered them. Name facts are also kept out of the facts list on purpose, so they do not pass for relations. The result was that nothing in the interface showed what an entity is also called.The extraction audit behind #710 found that this is where wrong merges start. "OpenAI's", "ChatGPT apps" and "… dated 2020-xx-xx" were recorded as aliases. "deep reinforcement learning" was recorded as an alias of "reinforcement learning", the pair the governance bench keeps merging. None of these could be seen until they had caused a merge.
Change
api.ts:NameViewandnamesonentityDetail.POST /kbs/{id}/facts/{fact_id}/reject). It is audited and appears in History. Renaming stays in the edit dialog.No server change.
Checks
tsc --noEmit,pnpm guard(style guard) andvitest(57 tests) pass.Waiting for a look before merge.
🤖 Generated with Claude Code