Skip to content

[zero Init] fix regression #1373

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjruwase merged 3 commits into from
Sep 16, 2021
Merged

[zero Init] fix regression #1373

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f128017
[zero Init] fix regression
stas00 Sep 15, 2021
1a4899d
clean up the warning
stas00 Sep 15, 2021
1ff341f
Merge branch 'master' into zero_init_deprecated_config_fix
tjruwase Sep 15, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion deepspeed/runtime/zero/partition_parameters.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
from .offload_constants import *

from ..utils import see_memory_usage
from deepspeed.utils import log_dist, init_distributed
from deepspeed.utils import log_dist, init_distributed, logger
from deepspeed.utils.debug import debug_param2name_id_shape, debug_param2name_id_shape_device, debug_module2name, debug_param2name, debug_param2name_id_shape_status, printflock, log_rank_file

from ..swap_tensor.partitioned_param_swapper import AsyncPartitionedParameterSwapper, PartitionedParamStatus
Expand Down Expand Up @@ -450,6 +450,12 @@ def get_model():

model = deepspeed.zero.Init(module=model)
"""
if config is not None:
config_dict_or_path = config
logger.warning(
f'zero.Init: the `config` argument is deprecated. Please use `config_dict_or_path` instead.'
)

_ds_config = DeepSpeedConfig(config_dict_or_path,
mpu) if config_dict_or_path is not None else None
super().__init__(enabled=enabled,
Expand Down