document about engine.load_checkpoint() - #1457
Merged
Merged
Conversation
skpig
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
October 17, 2021 12:11
Contributor
Author
|
It is my first time to make a PR. If I did anything wrong, please forgive me. It will be appreciated if anyone could give me some advice. |
Collaborator
|
Looks great to me, @skpig! Could you please test if the problem occurs only with ZeRO3? It's most likely the case, but it'd be good to validate that ZeRO2 doesn't have this limitation. |
Contributor
Author
|
I just checked. The issue doesn't occur under ZeRO2. |
Collaborator
tjruwase
approved these changes
Oct 18, 2021
Contributor
Dipet
pushed a commit
to Dipet/DeepSpeed
that referenced
this pull request
Oct 26, 2021
Co-authored-by: skpig <1900012999@pku.edu.cn>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About issue #1394. Add document about
engine.load_checkpoint()explaining the limitation under ZeRO3. @stas00