Add warmup_type arguments in WarmupLR and WarmupDecayLR - #1530
Merged
Merged
Conversation
skpig
requested review from
RezaYazdaniAminabadi,
ShadenSmith,
awan-10,
cli99,
conglongli,
eltonzheng,
jeffra,
minjiaz,
niumanar,
samyam and
tjruwase
as code owners
November 6, 2021 09:14
|
|
Contributor
|
Thanks. These looks good. Could you please add some unit tests for this here? |
Contributor
Author
|
When I ran |
Contributor
|
@skpig, not a problem for now since the CI will also run the tests. I will investigate any failures. |
Contributor
Author
|
Any problems during review? If so, please feel free to at me. |
tjruwase
reviewed
Nov 11, 2021
tjruwase
approved these changes
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
About issue #1298 @tjruwase
I add
warmup_typearguments in WarmupLR and WarmupDecayLR. Iflogis chosen(Default) , the training curve will be the same as before. Iflinear, then learning rate will increase linearly during warmup.