You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the change in the current PR, when weight and bias are provided as input to the __init__ function, they are no longer Parameter of the module (mp_replace.copy isn't called anymore and the current code won't wrap weight and bias into Parameter anymore).
May I know if this change is intended?
Hi @molly-smith, before this PR, the weight and bias of LinearLayer and LinearAllreduce are created by mp_replace.copy, the output of which is a nn.Parameter():
With the change in the current PR, when weight and bias are provided as input to the __init__ function, they are no longer Parameter of the module (mp_replace.copy isn't called anymore and the current code won't wrap weight and bias into Parameter anymore). May I know if this change is intended?
Hi @chunyuan-w, thanks for bringing this to my attention. This was not intentional. Will have a fix soon.
With the change in the current PR, when weight and bias are provided as input to the __init__ function, they are no longer Parameter of the module (mp_replace.copy isn't called anymore and the current code won't wrap weight and bias into Parameter anymore). May I know if this change is intended?
Hi @chunyuan-w, thanks for bringing this to my attention. This was not intentional. Will have a fix soon.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor replace_wo_policy with autoTP class functions. AutoTP class functions will be reused in Hybrid Engine in follow-up PR.
Remove new tensor allocation for weights and biases to reduce memory.
Some gpt2 bug fixes.