[Bug fix] Add rope_theta for llama config - #4480
Merged
Merged
Conversation
cupertank
requested review from
RezaYazdaniAminabadi,
arashb,
awan-10,
cmikeh2,
jeffra and
mrwyattii
as code owners
October 9, 2023 15:29
Contributor
Author
|
@microsoft-github-policy-service agree company="JetBrains" |
Contributor
Author
|
@mrwyattii Take a look at this, please. |
Contributor
Author
|
@mrwyattii, Please, run CI. Do I need to do anything else? |
mrwyattii
approved these changes
Oct 13, 2023
Contributor
|
Thanks @cupertank LGTM |
Contributor
|
@cupertank it looks like several of the inference related unit tests are failing. I can help debug next week. |
Contributor
Author
|
@mrwyattii I think I found a bug, run CI, please. |
Contributor
Author
|
@mrwyattii I hope it's last fix, run CI, please |
Contributor
Author
|
@mrwyattii I see everything is good now, so maybe we merge it? |
Contributor
Added to the merge queue. Thank you @cupertank! |
|
Do you plan to have a patch release for this? |
baodii
pushed a commit
to baodii/DeepSpeed
that referenced
this pull request
Nov 7, 2023
* Add rope_theta for llama config * Add rope_theta to bias_add_transform_0213 * Fix CI problems * Add rope_theta to linear layer --------- Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com> Co-authored-by: Lev Kurilenko <113481193+lekurile@users.noreply.github.com>
mrwyattii
added a commit
that referenced
this pull request
Nov 8, 2023
This PR updates `diffusers_attention` to properly pass the `rope_theta` arg to the `linear_func` calls. This was added in GH-4480 and needed to be updated for the diffusers attention module as well. Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com>
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
* Add rope_theta for llama config * Add rope_theta to bias_add_transform_0213 * Fix CI problems * Add rope_theta to linear layer --------- Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com> Co-authored-by: Lev Kurilenko <113481193+lekurile@users.noreply.github.com>
mauryaavinash95
pushed a commit
to mauryaavinash95/DeepSpeed
that referenced
this pull request
Feb 17, 2024
This PR updates `diffusers_attention` to properly pass the `rope_theta` arg to the `linear_func` calls. This was added in deepspeedaiGH-4480 and needed to be updated for the diffusers attention module as well. Co-authored-by: Michael Wyatt <michaelwyatt@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed bug with CodeLlama. Bug description is here #4442. Now DeepSpeed uses rope_theta from transformers.