hyperdrive 0.20.1; fix checkpoint exposure bug - #207
Merged
Merged
Conversation
dpaiton
commented
Dec 18, 2024
dpaiton
force-pushed
the
dpaiton/remove-checkpoint-exposure
branch
3 times, most recently
from
December 18, 2024 17:59
f578aaa to
c2dcff6
Compare
dpaiton
marked this pull request as ready for review
December 18, 2024 17:59
dpaiton
force-pushed
the
dpaiton/remove-checkpoint-exposure
branch
from
December 19, 2024 20:51
c2dcff6 to
ea954c9
Compare
Contributor
Author
|
Per conversations with @jalextowle, the checkpoint exposure is ok to leave alone in the Long flow. This PR only updates the short flow to avoid double counting exposure. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A Hyperdrive update from this time last year (delvtech/hyperdrive#692) reworked exposure such that the state
long_exposurevariable included exposure adjustments from any current trade, without representing negative exposure. For example, here is the latest code for long exposure in open short. This update did not get fully propagated to the short side of the rust SDK. The long side can remain unchanged since negative checkpoint exposure can net out future longs, which is not accounted for in thestate.long_exposurevariable.This PR implements the fix. I will do a round of updating test tolerances once the remaining max short fixes are implemented.
The commits are organized to separate meaningful changes from regex propagation.