Uh oh!
There was an error while loading. Please reload this page.
Fix image-upgrade, test suite 'suite_group_clean_config', and test case 'test_switch_reload_all' - #10
Closed
alisaycl96 wants to merge 2 commits into
Closed
Fix image-upgrade, test suite 'suite_group_clean_config', and test case 'test_switch_reload_all'#10alisaycl96 wants to merge 2 commits into
alisaycl96 wants to merge 2 commits into
Conversation
rothcar
previously approved these changes
Oct 14, 2021
rothcar
left a comment
Collaborator
There was a problem hiding this comment.
LGTM. Test suite still had some leftover hacks from our lab setup, thanks for catching that.
isgmano
self-requested a review
October 21, 2021 15:02
alisaycl96force-pushed
the
master
branch
2 times, most recently
from
October 22, 2021 06:38
82937fd to
5e14dc0Compareisgmano
previously approved these changes
Oct 24, 2021
rothcar
previously approved these changes
Oct 26, 2021
taraschornyiplv
previously approved these changes
Oct 26, 2021
…ents.txt 2) Fix the image-upgrade by modifying the script name from 'onie-select' into 'dent_boot_select' 3) Fix the test suite 'suite_group_clean_config' by deleting 'infra_sw1_KEEPALIVED_CONF' and taking out the unnecessary code of staging file in 'test_clean_config.py' Signed-off-by: Alisa Li alisa_li@accton.com Signed-off-by: Alisa Li <alisa_li@accton.com>
alisaycl96
dismissed stale reviews from taraschornyiplv, rothcar, and isgmano
via
October 28, 2021 03:16
f2d173ealisaycl96force-pushed
the
master
branch
2 times, most recently
from
November 4, 2021 07:40
9ff6619 to
f2d173eComparerobimarko
approved these changes
Nov 9, 2021
robimarko
commented
Nov 9, 2021
LGTM, just remove the merge commit |
alisaycl96
commented
Nov 11, 2021
Author
This commit has been added to the new PR#11, so closed this one. |
mgheorghe pushed a commit
that referenced
this pull request
Aug 8, 2023
hubogee pushed a commit
to hubogee/testing
that referenced
this pull request
Aug 22, 2023
* Fix Password Policy for CI (dentproject#384) Fix Dockerfile Run Naming * Fix Docker Container Naming --------- Signed-off-by: fkwilken <fkwilken@gmail.com>
hubogee added a commit
to hubogee/testing
that referenced
this pull request
Aug 22, 2023
* Updated testbed files and Network interfaces files Signed-off-by: hubogee <hubogee@gmail.com> * Optimize VPort Addition, Protocol Timing (dentproject#386) Signed-off-by: fkwilken <fkwilken@gmail.com> * Pr fix dockerfile (dentproject#10) (dentproject#388) * Fix Password Policy for CI (dentproject#384) Fix Dockerfile Run Naming * Fix Docker Container Naming --------- Signed-off-by: fkwilken <fkwilken@gmail.com> * Added testbed device details: PDU, Mac, cpu architecture Signed-off-by: hubogee <hubogee@gmail.com> --------- Signed-off-by: hubogee <hubogee@gmail.com> Signed-off-by: fkwilken <fkwilken@gmail.com> Co-authored-by: Francisco <74398368+fkwilken@users.noreply.github.com>
hubogee added a commit
to hubogee/testing
that referenced
this pull request
Aug 22, 2023
* Updated testbed files and Network interfaces files Signed-off-by: hubogee <hubogee@gmail.com> * Optimize VPort Addition, Protocol Timing (dentproject#386) Signed-off-by: fkwilken <fkwilken@gmail.com> * Pr fix dockerfile (dentproject#10) (dentproject#388) * Fix Password Policy for CI (dentproject#384) Fix Dockerfile Run Naming * Fix Docker Container Naming --------- Signed-off-by: fkwilken <fkwilken@gmail.com> * Added testbed device details: PDU, Mac, cpu architecture Signed-off-by: hubogee <hubogee@gmail.com> --------- Signed-off-by: hubogee <hubogee@gmail.com> Signed-off-by: fkwilken <fkwilken@gmail.com> Co-authored-by: Francisco <74398368+fkwilken@users.noreply.github.com> Signed-off-by: hubogee <hubogee@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Alisa Li alisa_li@accton.com