Ignore any calls to increment_metric as irrelevant

[brrygrdn]

As title, we don't need to handle or set expectations on these calls.

[jakecoffman]

Do we want to log them?

[brrygrdn]

@jakecoffman I was 50/50 on that, I was thinking of it mostly as 'I'm not sure anyone but us cares about instrumentation', but I guess their information is likely useful to have in the logs?

[jakecoffman]

I would only be concerned that someone is confused why isn't working since it's eating it quietly instead of eating it loudly.

[brrygrdn]

 proxy | 2023/04/06 14:05:59 [008] 200 http://host.docker.internal:57761/update_jobs/cli/update_dependency_list
proxy | 2023/04/06 14:05:59 [009] POST http://host.docker.internal:57761/update_jobs/cli/increment_metric
{"data":{"metric":"updater.started","tags":{"operation":"Dependabot::Updater::Operations::UpdateAllVersions"}},"type":"increment_metric"}
proxy | 2023/04/06 14:05:59 [009] 200 http://host.docker.internal:57761/update_jobs/cli/increment_metric
updater | 2023/04/06 14:05:59 INFO Starting update job for rsc/quote

@jakecoffman I've updated it to output the data, I think it makes more sense. I'll need to tweak the value of the operation in Core to avoid returning the full namespace 😅

[jakecoffman]

LGTM looks like it just needs a run through the Go formatter.

[brrygrdn]

As title, we don't need to handle or set expectations on these calls.

[jakecoffman]

Do we want to log them?

[brrygrdn]

@jakecoffman I was 50/50 on that, I was thinking of it mostly as 'I'm not sure anyone but us cares about instrumentation', but I guess their information is likely useful to have in the logs?

[jakecoffman]

I would only be concerned that someone is confused why isn't working since it's eating it quietly instead of eating it loudly.

[brrygrdn]

 proxy | 2023/04/06 14:05:59 [008] 200 http://host.docker.internal:57761/update_jobs/cli/update_dependency_list
proxy | 2023/04/06 14:05:59 [009] POST http://host.docker.internal:57761/update_jobs/cli/increment_metric
{"data":{"metric":"updater.started","tags":{"operation":"Dependabot::Updater::Operations::UpdateAllVersions"}},"type":"increment_metric"}
proxy | 2023/04/06 14:05:59 [009] 200 http://host.docker.internal:57761/update_jobs/cli/increment_metric
updater | 2023/04/06 14:05:59 INFO Starting update job for rsc/quote

@jakecoffman I've updated it to output the data, I think it makes more sense. I'll need to tweak the value of the operation in Core to avoid returning the full namespace 😅

[jakecoffman]

LGTM looks like it just needs a run through the Go formatter.

[brrygrdn]

As title, we don't need to handle or set expectations on these calls.

[jakecoffman]

Do we want to log them?

[brrygrdn]

@jakecoffman I was 50/50 on that, I was thinking of it mostly as 'I'm not sure anyone but us cares about instrumentation', but I guess their information is likely useful to have in the logs?

[jakecoffman]

I would only be concerned that someone is confused why isn't working since it's eating it quietly instead of eating it loudly.

[brrygrdn]

 proxy | 2023/04/06 14:05:59 [008] 200 http://host.docker.internal:57761/update_jobs/cli/update_dependency_list
proxy | 2023/04/06 14:05:59 [009] POST http://host.docker.internal:57761/update_jobs/cli/increment_metric
{"data":{"metric":"updater.started","tags":{"operation":"Dependabot::Updater::Operations::UpdateAllVersions"}},"type":"increment_metric"}
proxy | 2023/04/06 14:05:59 [009] 200 http://host.docker.internal:57761/update_jobs/cli/increment_metric
updater | 2023/04/06 14:05:59 INFO Starting update job for rsc/quote

@jakecoffman I've updated it to output the data, I think it makes more sense. I'll need to tweak the value of the operation in Core to avoid returning the full namespace 😅

[jakecoffman]

LGTM looks like it just needs a run through the Go formatter.

[brrygrdn]

As title, we don't need to handle or set expectations on these calls.

[jakecoffman]

Do we want to log them?

[brrygrdn]

@jakecoffman I was 50/50 on that, I was thinking of it mostly as 'I'm not sure anyone but us cares about instrumentation', but I guess their information is likely useful to have in the logs?

[jakecoffman]

I would only be concerned that someone is confused why isn't working since it's eating it quietly instead of eating it loudly.

[brrygrdn]

 proxy | 2023/04/06 14:05:59 [008] 200 http://host.docker.internal:57761/update_jobs/cli/update_dependency_list
proxy | 2023/04/06 14:05:59 [009] POST http://host.docker.internal:57761/update_jobs/cli/increment_metric
{"data":{"metric":"updater.started","tags":{"operation":"Dependabot::Updater::Operations::UpdateAllVersions"}},"type":"increment_metric"}
proxy | 2023/04/06 14:05:59 [009] 200 http://host.docker.internal:57761/update_jobs/cli/increment_metric
updater | 2023/04/06 14:05:59 INFO Starting update job for rsc/quote

@jakecoffman I've updated it to output the data, I think it makes more sense. I'll need to tweak the value of the operation in Core to avoid returning the full namespace 😅

[jakecoffman]

LGTM looks like it just needs a run through the Go formatter.

[brrygrdn]

As title, we don't need to handle or set expectations on these calls.

[jakecoffman]

Do we want to log them?

[brrygrdn]

@jakecoffman I was 50/50 on that, I was thinking of it mostly as 'I'm not sure anyone but us cares about instrumentation', but I guess their information is likely useful to have in the logs?

[jakecoffman]

I would only be concerned that someone is confused why isn't working since it's eating it quietly instead of eating it loudly.

[brrygrdn]

 proxy | 2023/04/06 14:05:59 [008] 200 http://host.docker.internal:57761/update_jobs/cli/update_dependency_list
proxy | 2023/04/06 14:05:59 [009] POST http://host.docker.internal:57761/update_jobs/cli/increment_metric
{"data":{"metric":"updater.started","tags":{"operation":"Dependabot::Updater::Operations::UpdateAllVersions"}},"type":"increment_metric"}
proxy | 2023/04/06 14:05:59 [009] 200 http://host.docker.internal:57761/update_jobs/cli/increment_metric
updater | 2023/04/06 14:05:59 INFO Starting update job for rsc/quote

@jakecoffman I've updated it to output the data, I think it makes more sense. I'll need to tweak the value of the operation in Core to avoid returning the full namespace 😅

[jakecoffman]

LGTM looks like it just needs a run through the Go formatter.

[brrygrdn]

As title, we don't need to handle or set expectations on these calls.

[jakecoffman]

Do we want to log them?

[brrygrdn]

@jakecoffman I was 50/50 on that, I was thinking of it mostly as 'I'm not sure anyone but us cares about instrumentation', but I guess their information is likely useful to have in the logs?

[jakecoffman]

I would only be concerned that someone is confused why isn't working since it's eating it quietly instead of eating it loudly.

[brrygrdn]

 proxy | 2023/04/06 14:05:59 [008] 200 http://host.docker.internal:57761/update_jobs/cli/update_dependency_list
proxy | 2023/04/06 14:05:59 [009] POST http://host.docker.internal:57761/update_jobs/cli/increment_metric
{"data":{"metric":"updater.started","tags":{"operation":"Dependabot::Updater::Operations::UpdateAllVersions"}},"type":"increment_metric"}
proxy | 2023/04/06 14:05:59 [009] 200 http://host.docker.internal:57761/update_jobs/cli/increment_metric
updater | 2023/04/06 14:05:59 INFO Starting update job for rsc/quote

@jakecoffman I've updated it to output the data, I think it makes more sense. I'll need to tweak the value of the operation in Core to avoid returning the full namespace 😅

[jakecoffman]

LGTM looks like it just needs a run through the Go formatter.

[brrygrdn]

As title, we don't need to handle or set expectations on these calls.

[jakecoffman]

Do we want to log them?

[brrygrdn]

@jakecoffman I was 50/50 on that, I was thinking of it mostly as 'I'm not sure anyone but us cares about instrumentation', but I guess their information is likely useful to have in the logs?

[jakecoffman]

I would only be concerned that someone is confused why isn't working since it's eating it quietly instead of eating it loudly.

[brrygrdn]

 proxy | 2023/04/06 14:05:59 [008] 200 http://host.docker.internal:57761/update_jobs/cli/update_dependency_list
proxy | 2023/04/06 14:05:59 [009] POST http://host.docker.internal:57761/update_jobs/cli/increment_metric
{"data":{"metric":"updater.started","tags":{"operation":"Dependabot::Updater::Operations::UpdateAllVersions"}},"type":"increment_metric"}
proxy | 2023/04/06 14:05:59 [009] 200 http://host.docker.internal:57761/update_jobs/cli/increment_metric
updater | 2023/04/06 14:05:59 INFO Starting update job for rsc/quote

@jakecoffman I've updated it to output the data, I think it makes more sense. I'll need to tweak the value of the operation in Core to avoid returning the full namespace 😅

[jakecoffman]

LGTM looks like it just needs a run through the Go formatter.

[brrygrdn]

As title, we don't need to handle or set expectations on these calls.

[jakecoffman]

Do we want to log them?

[brrygrdn]

@jakecoffman I was 50/50 on that, I was thinking of it mostly as 'I'm not sure anyone but us cares about instrumentation', but I guess their information is likely useful to have in the logs?

[jakecoffman]

I would only be concerned that someone is confused why isn't working since it's eating it quietly instead of eating it loudly.

[brrygrdn]

 proxy | 2023/04/06 14:05:59 [008] 200 http://host.docker.internal:57761/update_jobs/cli/update_dependency_list
proxy | 2023/04/06 14:05:59 [009] POST http://host.docker.internal:57761/update_jobs/cli/increment_metric
{"data":{"metric":"updater.started","tags":{"operation":"Dependabot::Updater::Operations::UpdateAllVersions"}},"type":"increment_metric"}
proxy | 2023/04/06 14:05:59 [009] 200 http://host.docker.internal:57761/update_jobs/cli/increment_metric
updater | 2023/04/06 14:05:59 INFO Starting update job for rsc/quote

@jakecoffman I've updated it to output the data, I think it makes more sense. I'll need to tweak the value of the operation in Core to avoid returning the full namespace 😅

[jakecoffman]

LGTM looks like it just needs a run through the Go formatter.