Skip to content

Hang when a directory must be ignored due to e.g. many files or circular references, but the gitignore that instructs to ignore it is not in the root. #115

Description

@chrissimon-au

Describe the bug
See discussion on #108 .

To Reproduce

|--- app.glossary.yml
|--- src/
|--- node_modules/ <-- contains circular links
|--- .gitignore <-- contains `node_modules` as an ignore entry

This will fail to find app.glossary.yml because the glob search operation will 'hang' while searching node_modules. the .gitignore in the src folder doesn't apply because the hang occurs when we are searching for .gitignore files in the first place.

Expected behavior
It should ignore node_modules because of the adjacent .gitignore and as a result, not hang and eventually find app.glossary.yml

Additional context

gitignore support was first added on #109

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions