fix(a11y): give the view switcher and the exit mode real semantics - #17
Merged
devRMA merged 1 commit intoAug 2, 2026
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
codecov-commenter
commented
Aug 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Closes the two blocked items from #13. The Jornada / Custo da Hora pair swaps the main panel, so it was neither navigation nor a pair of independent toggles. It is now real links carrying the view in the query string, marked with aria-current. That also makes the active tab shareable and bookmarkable - it used to live in useState - and restores Cmd-click and middle-click. Reading the view through useSearchParams forces a Suspense boundary, so the nav and the panel moved into one organism rendered inside it, with the journey view as the fallback. The prerendered HTML still carries the whole shell and / stays static. AUTO/MANUAL was two aria-pressed buttons: assistive tech announced two independent toggles, with no mutual exclusion, two tab stops and no arrow-key navigation. Two radios in a fieldset let the platform supply grouping, aria-checked, arrow keys and the roving tab stop for no JS. The input covers the label rather than sitting in an sr-only corner, so the click target matches what is actually visible. Selectors in both e2e specs follow the new roles. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
devRMAforce-pushed
the
fix/a11y-tabs-and-radio-group
branch
from
August 2, 2026 18:46
abdebd6 to
f5f2f41CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes the two blocked items from #13.
The Jornada / Custo da Hora pair swaps the main panel, so it was neither
navigation nor a pair of independent toggles. It is now real links
carrying the view in the query string, marked with aria-current. That
also makes the active tab shareable and bookmarkable - it used to live
in useState - and restores Cmd-click and middle-click.
Reading the view through useSearchParams forces a Suspense boundary, so
the nav and the panel moved into one organism rendered inside it, with
the journey view as the fallback. The prerendered HTML still carries the
whole shell and / stays static.
AUTO/MANUAL was two aria-pressed buttons: assistive tech announced two
independent toggles, with no mutual exclusion, two tab stops and no
arrow-key navigation. Two radios in a fieldset let the platform supply
grouping, aria-checked, arrow keys and the roving tab stop for no JS.
The input covers the label rather than sitting in an sr-only corner, so
the click target matches what is actually visible.
Selectors in both e2e specs follow the new roles.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Stack created with GitHub Stacks CLI • Give Feedback 💬