fix(ui): clear the smaller items from #13 - #19
Merged
Conversation
The latest updates on your projects. Learn more about Vercel for GitHub.
|
codecov-commenter
commented
Aug 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Uh oh!
There was an error while loading. Please reload this page.
Currency fields reformatted on every keystroke, so React's written value differed from what was typed and the browser reset the caret to the end. Appending felt fine; editing mid-string threw the caret to the end each character. A CurrencyInput now restores the caret by counting the digits to its right, so mid-string editing survives. Verified in Chromium: two consecutive edits at position 1 keep the caret next to the typed digit. formatCurrency and formatCurrencySimple built a fresh Intl.NumberFormat per call, which is once per keystroke on a controlled input. Both formatters are hoisted to module scope, joined by a clock formatter that replaces a hand-written HH:mm:ss format string. The locale stays pinned to pt-BR on purpose, matching lang="pt-BR" and the BRL amounts beside it - a visitor-derived locale would print the clock in a different convention from the rest of the interface. Resetar Horários wiped every entered time with no confirmation and no undo; it now asks first. Side ads rendered from 2xl (>=1536px) while the content container is 1600px wide, so they sat on top of the content. Gated at 1980px, which measurement confirms is where they first clear it: ads at 16..176 and 1804..1964 against content at 190..1790. The e2e skip threshold follows. Also: input defaults for autoComplete, spellCheck and enterKeyHint; preconnect for the two Google origins fetched at runtime; safe-area insets on the bottom-anchored nav, cookie banner and privacy button; and a smaller vertical padding below sm, where 256px of fixed padding left only 200px usable at 375x667 landscape. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
devRMAforce-pushed
the
fix/issue-13-minor-items
branch
from
August 2, 2026 18:46
b709e8c to
4a9afc6CompareUh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currency fields reformatted on every keystroke, so React's written value
differed from what was typed and the browser reset the caret to the end.
Appending felt fine; editing mid-string threw the caret to the end each
character. A CurrencyInput now restores the caret by counting the digits
to its right, so mid-string editing survives. Verified in Chromium: two
consecutive edits at position 1 keep the caret next to the typed digit.
formatCurrency and formatCurrencySimple built a fresh Intl.NumberFormat
per call, which is once per keystroke on a controlled input. Both
formatters are hoisted to module scope, joined by the clock formatter -
times were formatted with a hardcoded HH:mm:ss instead of the visitor's
locale.
Resetar Horários wiped every entered time with no confirmation and no
undo; it now asks first.
Side ads rendered from 2xl (>=1536px) while the content container is
1600px wide, so they sat on top of the content. Gated at 1980px, which
measurement confirms is where they first clear it: ads at 16..176 and
1804..1964 against content at 190..1790. The e2e skip threshold follows.
Also: input defaults for autoComplete, spellCheck and enterKeyHint;
preconnect for the two Google origins fetched at runtime; safe-area
insets on the bottom-anchored nav, cookie banner and privacy button; and
a smaller vertical padding below sm, where 256px of fixed padding left
only 200px usable at 375x667 landscape.
Co-Authored-By: Claude Opus 5 noreply@anthropic.com
Stack created with GitHub Stacks CLI • Give Feedback 💬