feat(salary): accept minutes in the daily journey - #24
Merged
Conversation
The field only took whole hours, so a 44h week (08:48 a day) could not be entered and every per-day and per-week value was off. It now uses the same HH:MM mask as the Jornada tab, and the state is kept in minutes with 08:48 as the default to match the 220h month. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The latest updates on your projects. Learn more about Vercel for GitHub.
|
codecov-commenter
commented
Aug 2, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Uh oh!
There was an error while loading. Please reload this page.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for freeto join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The field only took whole hours, so a 44h week (08:48 a day) could not
be entered and every per-day and per-week value was off. It now uses the
same HH:MM mask as the Jornada tab, and the state is kept in minutes
with 08:48 as the default to match the 220h month.
Storage key moves from
dailyHourstodailyMinutes; a stored 8 wouldotherwise be read as 8 minutes.
Stack created with GitHub Stacks CLI • Give Feedback 💬