Skip to content
Closed
Changes from all commits
Commits
Show all changes
95 commits
Select commit Hold shift + click to select a range
80a663b
Docs: cross-refactoring 再々検証の対象 PR を作る
takemi-ohama Aug 18, 2026
ffc933a
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 18, 2026
49c075e
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 18, 2026
9b7f7c0
Refactor: extract_method — plugins/ndf-shared/skills/cross-review/scr…
takemi-ohama Aug 18, 2026
cfb9d48
Refactor: extract_method — plugins/ndf-shared/skills/cross-review/scr…
takemi-ohama Aug 18, 2026
dd7f9a8
Refactor: extract_method — plugins/ndf-shared/skills/cross-review/scr…
takemi-ohama Aug 18, 2026
f210919
Refactor: extract_method — plugins/ndf-shared/skills/cross-review/scr…
takemi-ohama Aug 18, 2026
1ba3f77
Refactor: extract_method — plugins/ndf-shared/skills/cross-review/scr…
takemi-ohama Aug 18, 2026
b884ae8
Refactor: consolidate_duplication — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 18, 2026
685774b
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 18, 2026
b535305
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 18, 2026
3685c22
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 18, 2026
53706cf
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 18, 2026
bd3f0b7
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 18, 2026
e300048
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 18, 2026
ad295d4
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 18, 2026
e5185a3
Refactor: introduce_parameter_object — plugins/ndf-shared/skills/cros…
takemi-ohama Aug 18, 2026
c80bff4
Refactor: consolidate_duplication — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 18, 2026
f13fb08
Revert "Refactor: consolidate_duplication — plugins/ndf-shared/skills…
takemi-ohama Aug 18, 2026
93f014f
Revert "Refactor: introduce_parameter_object — plugins/ndf-shared/ski…
takemi-ohama Aug 18, 2026
f78ae13
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
6ec72a8
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
a31cd0f
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
d5c805f
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
68012f9
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
8cb7435
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
da946dc
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
03178ec
Revert "Refactor: consolidate_duplication — plugins/ndf-shared/skills…
takemi-ohama Aug 18, 2026
e4f729d
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
630516a
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
b815d90
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
f6530ad
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
11d3317
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
55f6b8e
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
902c648
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
c56bbb2
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 18, 2026
d29f988
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 18, 2026
42060bc
Refactor: consolidate_duplication — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 18, 2026
546ad38
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 18, 2026
c17ecea
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 18, 2026
025b357
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 18, 2026
0847bb3
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 18, 2026
0ba7901
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 18, 2026
428df3a
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 18, 2026
bd1eb76
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 18, 2026
131f9d3
Refactor: introduce_parameter_object — plugins/ndf-shared/skills/cros…
takemi-ohama Aug 18, 2026
db4866e
Refactor: consolidate_duplication — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 18, 2026
3c1f293
Chore: 生成物を同期する(cross-refactoring 進行側)
takemi-ohama Aug 18, 2026
6506503
Revert "Chore: 生成物を同期する(cross-refactoring 進行側)"
takemi-ohama Aug 18, 2026
6e654d4
Revert "Refactor: consolidate_duplication — plugins/ndf-shared/skills…
takemi-ohama Aug 18, 2026
62f66f0
Revert "Refactor: introduce_parameter_object — plugins/ndf-shared/ski…
takemi-ohama Aug 18, 2026
7517a93
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
5adf6f4
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
ead1b87
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
121314c
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
f370c98
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
7265eb1
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
bcafefa
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
c8b686b
Revert "Refactor: consolidate_duplication — plugins/ndf-shared/skills…
takemi-ohama Aug 18, 2026
9b391bf
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
de239be
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
2a51865
Reapply "Refactor: extract_method — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 18, 2026
85bc325
Reapply "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cr…
takemi-ohama Aug 18, 2026
12630ff
Reapply "Refactor: extract_method — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 18, 2026
48ee3d6
Reapply "Refactor: extract_method — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 18, 2026
52f3da4
Reapply "Refactor: extract_method — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 18, 2026
68740f4
Reapply "Refactor: extract_method — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 18, 2026
08ccd30
Reapply "Refactor: extract_method — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 18, 2026
8b9fca1
Reapply "Refactor: consolidate_duplication — plugins/ndf-shared/skill…
takemi-ohama Aug 18, 2026
c6d998e
Reapply "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cr…
takemi-ohama Aug 18, 2026
cf17a1c
Reapply "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cr…
takemi-ohama Aug 18, 2026
d7b71c3
Reapply "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cr…
takemi-ohama Aug 18, 2026
b9ad339
Reapply "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cr…
takemi-ohama Aug 18, 2026
7286de0
Reapply "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cr…
takemi-ohama Aug 18, 2026
99fb8a3
Reapply "Refactor: extract_method — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 18, 2026
21e8436
Reapply "Refactor: extract_method — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 18, 2026
fe86378
Reapply "Refactor: introduce_parameter_object — plugins/ndf-shared/sk…
takemi-ohama Aug 18, 2026
cbd1222
Reapply "Refactor: consolidate_duplication — plugins/ndf-shared/skill…
takemi-ohama Aug 18, 2026
685e6e5
Revert "Refactor: consolidate_duplication — plugins/ndf-shared/skills…
takemi-ohama Aug 18, 2026
51950c4
Revert "Refactor: introduce_parameter_object — plugins/ndf-shared/ski…
takemi-ohama Aug 18, 2026
23b5e17
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
4ad30db
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
c9aa502
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
063cdf8
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
4578ba6
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
8ac4882
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
d227062
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
027da76
Revert "Refactor: consolidate_duplication — plugins/ndf-shared/skills…
takemi-ohama Aug 18, 2026
0f7d0dc
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
514159a
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
6b9d581
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
2e8fd8f
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
3a01837
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
1cccb48
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 18, 2026
bfbe628
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 18, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
47 changes: 47 additions & 0 deletions issues/issue-113-cross-refactoring-re-retrial.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,47 @@
# cross-refactoring 再々検証(3 回目)

`/ndf:cross-refactoring` の**未到達 2 経路**を実機で通すための Pull Request。
経緯は [引継ぎメモ](issue-113-cross-refactoring-re-retrial-handoff.md) にある。

## 通したい経路

| 経路 | 何が観測できれば通ったと言えるか |
| --- | --- |
| 指摘の修正と再レビュー | `merge-fix` が修正コミットを取り込み、再レビューで判定が変わる |
| 上限到達時の項目単位の見送り | `should-abandon` が上限到達を返し、`abandon-items` が未解決の項目だけ取り消す |

あわせて、PR #121 で入れた次の 3 経路も実機で確認する。

| 対象 | 確認内容 |
| --- | --- |
| 公開の責務 | 実装担当が push せず、`merge-apply` の後に進行側が push する |
| 生成物の同期 | 同期コミットが push の直前に積まれる |
| 対象外への記録 | 適用で失敗した項目が次ラウンドの提案で再採用されない |

## 実行条件

2 回目はラウンド 1 で両レビュー担当とも指摘 0 件だったため、修正と見送りの経路へ
到達できなかった。3 回目は指摘が出る確率を上げる 2 つの調整を併用する。

| 引数 | 値 | 狙い |
| --- | --- | --- |
| `--max-fix-rounds` | `1` | 指摘が 1 回の修正で解決しなければ、即 `should-abandon` へ到達する |
| `--max-items-per-round` | `8` | 採用件数を増やし、指摘が出る確率を上げる |
| `--max-outer-rounds` | `3` | 既定どおり |

```bash
export PLUGIN_ROOT=/work/ai-plugins/plugins/ndf-claude

/ndf:cross-refactoring <PR番号> \
--scope plugins/ndf-shared/skills/cross-refactoring/scripts \
plugins/ndf-shared/skills/cross-refactoring/tests \
plugins/ndf-shared/skills/cross-review/scripts/lib \
plugins/ndf-shared/skills/cross-review/tests \
--sync-command "bash scripts/build-runtime-plugins.sh" \
--baseline-test "uv run --with pytest python -m pytest \
plugins/ndf-shared/skills/cross-refactoring/tests \
plugins/ndf-shared/skills/cross-review/tests -q" \
--max-outer-rounds 3 --max-fix-rounds 1 --max-items-per-round 8
```

着手前のテストは 444 件が通ることを確認済み。