Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
90 commits
Select commit Hold shift + click to select a range
a68ac24
Docs: cross-refactoring 6 回目の実機試行の手順を追加
takemi-ohama Aug 22, 2026
0aa1eb7
Refactor: extract_method — cross-review monitor.py#monitor_agent
takemi-ohama Aug 22, 2026
4ccc7f9
Refactor: extract_method — cross-review monitor.py#monitor_agent
takemi-ohama Aug 22, 2026
a1f8ac6
Refactor: extract_method — cross-review monitor.py#monitor_agent
takemi-ohama Aug 22, 2026
79de742
Refactor: extract_method — cross-review monitor.py#monitor_agent
takemi-ohama Aug 22, 2026
52391e3
Refactor: extract_method — cross-review monitor.py#monitor_agent
takemi-ohama Aug 22, 2026
a302bc2
Refactor: extract_method — cross-review monitor.py#monitor_agent
takemi-ohama Aug 22, 2026
8e94747
Refactor: extract_method — cross-review monitor.py#monitor_agent
takemi-ohama Aug 22, 2026
6d56e84
Refactor: split_into_pipeline — cross-refactoring refactor.py#cmd_mer…
takemi-ohama Aug 22, 2026
3036057
Refactor: split_into_pipeline — cross-refactoring refactor.py#cmd_mer…
takemi-ohama Aug 22, 2026
4c67c4a
Refactor: split_into_pipeline — cross-refactoring refactor.py#cmd_mer…
takemi-ohama Aug 22, 2026
6003f5b
Refactor: split_into_pipeline — cross-refactoring refactor.py#cmd_mer…
takemi-ohama Aug 22, 2026
b78b7b5
Refactor: extract_method — cross-refactoring refactor.py#cmd_judge_re…
takemi-ohama Aug 22, 2026
9a54fce
Refactor: extract_method — cross-refactoring refactor.py#cmd_judge_re…
takemi-ohama Aug 22, 2026
32cd565
Refactor: split_into_pipeline — cross-review metrics.py#aggregate
takemi-ohama Aug 22, 2026
6019049
Refactor: split_into_pipeline — cross-review metrics.py#aggregate
takemi-ohama Aug 22, 2026
8ca3321
Refactor: split_into_pipeline — cross-review metrics.py#aggregate
takemi-ohama Aug 22, 2026
e5ff225
Revert "Refactor: split_into_pipeline — cross-review metrics.py#aggre…
takemi-ohama Aug 22, 2026
798a0d2
Revert "Refactor: split_into_pipeline — cross-review metrics.py#aggre…
takemi-ohama Aug 22, 2026
643a63e
Revert "Refactor: split_into_pipeline — cross-review metrics.py#aggre…
takemi-ohama Aug 22, 2026
940ab86
Revert "Refactor: extract_method — cross-refactoring refactor.py#cmd_…
takemi-ohama Aug 22, 2026
b57d623
Revert "Refactor: extract_method — cross-refactoring refactor.py#cmd_…
takemi-ohama Aug 22, 2026
90a26f7
Revert "Refactor: split_into_pipeline — cross-refactoring refactor.py…
takemi-ohama Aug 22, 2026
c9d422e
Revert "Refactor: split_into_pipeline — cross-refactoring refactor.py…
takemi-ohama Aug 22, 2026
922002e
Revert "Refactor: split_into_pipeline — cross-refactoring refactor.py…
takemi-ohama Aug 22, 2026
dcb8506
Revert "Refactor: split_into_pipeline — cross-refactoring refactor.py…
takemi-ohama Aug 22, 2026
879db88
Revert "Refactor: extract_method — cross-review monitor.py#monitor_ag…
takemi-ohama Aug 22, 2026
4699b06
Revert "Refactor: extract_method — cross-review monitor.py#monitor_ag…
takemi-ohama Aug 22, 2026
f189f43
Revert "Refactor: extract_method — cross-review monitor.py#monitor_ag…
takemi-ohama Aug 22, 2026
3066751
Revert "Refactor: extract_method — cross-review monitor.py#monitor_ag…
takemi-ohama Aug 22, 2026
eb35932
Revert "Refactor: extract_method — cross-review monitor.py#monitor_ag…
takemi-ohama Aug 22, 2026
3769343
Revert "Refactor: extract_method — cross-review monitor.py#monitor_ag…
takemi-ohama Aug 22, 2026
6fab0aa
Revert "Refactor: extract_method — cross-review monitor.py#monitor_ag…
takemi-ohama Aug 22, 2026
f0d5977
Refactor: split_into_pipeline — cross-refactoring refactor.py#cmd_mer…
takemi-ohama Aug 22, 2026
7dcebc1
Refactor: split_into_pipeline — cross-refactoring refactor.py#cmd_mer…
takemi-ohama Aug 22, 2026
658adc5
Refactor: split_into_pipeline — cross-refactoring refactor.py#cmd_mer…
takemi-ohama Aug 22, 2026
2b9dd8f
Refactor: split_into_pipeline — cross-refactoring refactor.py#cmd_mer…
takemi-ohama Aug 22, 2026
1696dea
Refactor: extract_method — cross-refactoring refactor.py#cmd_judge_re…
takemi-ohama Aug 22, 2026
fac4648
Refactor: extract_method — cross-refactoring refactor.py#cmd_judge_re…
takemi-ohama Aug 22, 2026
c102ec7
Refactor: split_into_pipeline — cross-review metrics.py#aggregate
takemi-ohama Aug 22, 2026
0619891
Refactor: split_into_pipeline — cross-review metrics.py#aggregate
takemi-ohama Aug 22, 2026
5deba1d
Refactor: split_into_pipeline — cross-review metrics.py#aggregate
takemi-ohama Aug 22, 2026
c6d6edf
Chore: 生成物を同期する(cross-refactoring 進行側)
takemi-ohama Aug 22, 2026
b4c44d5
Test: cmd_merge_fix の重複取り込みと未申告コミット拒否を現状固定する
takemi-ohama Aug 22, 2026
39eadd8
Refactor: extract_method — cross-refactoring refactor.py#cmd_merge_fix
takemi-ohama Aug 22, 2026
ea5cc93
Refactor: extract_method — cross-refactoring refactor.py#cmd_merge_fix
takemi-ohama Aug 22, 2026
e8d0061
Refactor: extract_method — cross-refactoring refactor.py#cmd_merge_fix
takemi-ohama Aug 22, 2026
9f84b63
Refactor: extract_method — cross-refactoring refactor.py#cmd_merge_fix
takemi-ohama Aug 22, 2026
d3518b4
Refactor: extract_method — cross-refactoring refactor.py#cmd_merge_pr…
takemi-ohama Aug 22, 2026
08e0cbf
Refactor: extract_method — cross-refactoring refactor.py#cmd_merge_pr…
takemi-ohama Aug 22, 2026
663bcb8
Refactor: extract_method — cross-refactoring refactor.py#_validate_ap…
takemi-ohama Aug 22, 2026
b172345
Refactor: extract_method — cross-refactoring refactor.py#_validate_ap…
takemi-ohama Aug 22, 2026
5dc2ab1
Refactor: extract_method — cross-refactoring refactor.py#_validate_ap…
takemi-ohama Aug 22, 2026
fe08565
Refactor: extract_method — cross-refactoring refactor.py#judge
takemi-ohama Aug 22, 2026
bfecfd8
Refactor: extract_method — cross-refactoring refactor.py#judge
takemi-ohama Aug 22, 2026
93d8d3d
Refactor: extract_method — cross-refactoring refactor.py#judge
takemi-ohama Aug 22, 2026
6a00ae8
Refactor: split_into_pipeline — cross-refactoring refactor.py#_drop_i…
takemi-ohama Aug 22, 2026
86016da
Refactor: split_into_pipeline — cross-refactoring refactor.py#_drop_i…
takemi-ohama Aug 22, 2026
421e878
Refactor: split_into_pipeline — cross-refactoring refactor.py#_drop_i…
takemi-ohama Aug 22, 2026
2764087
Refactor: split_into_pipeline — cross-refactoring refactor.py#_drop_i…
takemi-ohama Aug 22, 2026
4856c7e
Refactor: split_into_pipeline — cross-refactoring refactor.py#_drop_i…
takemi-ohama Aug 22, 2026
6977668
Chore: 生成物を同期する(cross-refactoring 進行側)
takemi-ohama Aug 22, 2026
107be5e
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 22, 2026
6eac882
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 22, 2026
beed674
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 22, 2026
299043c
Refactor: flatten_conditional — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 22, 2026
369bffa
Refactor: flatten_conditional — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 22, 2026
759a135
Refactor: flatten_conditional — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 22, 2026
af392b3
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 22, 2026
8864dc3
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 22, 2026
887471c
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 22, 2026
bb721ad
Refactor: consolidate_duplication — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 22, 2026
aed8d44
Revert "Refactor: consolidate_duplication — plugins/ndf-shared/skills…
takemi-ohama Aug 22, 2026
15e58b4
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 22, 2026
04c270f
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 22, 2026
5c853ee
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 22, 2026
91f3559
Revert "Refactor: flatten_conditional — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 22, 2026
5c65da1
Revert "Refactor: flatten_conditional — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 22, 2026
736721d
Revert "Refactor: flatten_conditional — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 22, 2026
aed535e
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 22, 2026
5470eb7
Revert "Refactor: split_into_pipeline — plugins/ndf-shared/skills/cro…
takemi-ohama Aug 22, 2026
0902327
Revert "Refactor: extract_method — plugins/ndf-shared/skills/cross-re…
takemi-ohama Aug 22, 2026
b37a447
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 22, 2026
7f52713
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 22, 2026
f28790a
Refactor: split_into_pipeline — plugins/ndf-shared/skills/cross-refac…
takemi-ohama Aug 22, 2026
e7ebc1b
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 22, 2026
c5e10ae
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 22, 2026
5a4acca
Refactor: extract_method — plugins/ndf-shared/skills/cross-refactorin…
takemi-ohama Aug 22, 2026
75f20b3
Refactor: consolidate_duplication — plugins/ndf-shared/skills/cross-r…
takemi-ohama Aug 22, 2026
fe9e396
Chore: 生成物を同期する(cross-refactoring 進行側)
takemi-ohama Aug 22, 2026
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
78 changes: 78 additions & 0 deletions issues/issue-113-cross-refactoring-6th-trial.md
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,78 @@
# cross-refactoring 6 回目の実機試行

Pull Request #133 / #134 / #135(NDF v8.5.2〜v8.5.4)で直した 4 件が実機で成立するかを
確かめる。あわせて、5 回の試行で一度も到達していない経路まで通す。

経緯は次の 5 つにある。

- [issue-113-cross-refactoring-trial-report.md](issue-113-cross-refactoring-trial-report.md) — 1 回目
- [issue-113-cross-refactoring-retrial.md](issue-113-cross-refactoring-retrial.md) — 2 回目
- [issue-113-cross-refactoring-re-retrial.md](issue-113-cross-refactoring-re-retrial.md) — 3 回目
- [issue-113-cross-refactoring-4th-trial-report.md](issue-113-cross-refactoring-4th-trial-report.md) — 4 回目
- [issue-113-cross-refactoring-5th-trial-report.md](issue-113-cross-refactoring-5th-trial-report.md) — 5 回目

## 目的

5 回目はレビューの投稿が成立せず、レビュー結果の欠落を理由に 2 ラウンド目で中断した。
投稿にまつわる 3 件と差分予算の 1 件を直したので、同じ構成でもう一度通す。

## 確かめること

| # | 直したこと | 何が観測できれば通ったと言えるか |
| --- | --- | --- |
| 18 | 自分の Pull Request では投稿の event を `COMMENT` へ倒す | レビュー担当が `HTTP 422` を受けずに投稿でき、結果ファイルの判定は `APPROVE` / `REQUEST_CHANGES` のまま残る |
| 19 | 投稿に失敗しても結果ファイルを書く | 投稿が失敗したラウンドで `post_error` 付きの結果ファイルが残り、担当の停止と投稿の失敗を区別できる |
| 20 | 投稿されたことを GitHub 側で確かめる | 結果ファイルのレビュー URL が必須になり、GitHub 側に無い判定は差し戻される |
| 21 | 抽出系の手法の差分予算 | `long_method` の抽出が見積の 2 倍をわずかに超えても採用され、範囲外を触った変更は落ちる |

## 到達したい範囲

5 回の試行で一度も到達していない。

| 対象 | 内容 |
| --- | --- |
| 提案の収束 | 新しい提案が出なくなって `advance` が繰り返しを終えるところ |
| 修正ラウンドの上限 | `should-abandon` から `abandon-items` へ進み、指摘が残る項目だけを取り消すところ |
| Step 7 の関門 | 収束後に `/ndf:cross-review` を Pull Request 全体へ実行するところ |
| Draft の解除 | Step 8 の報告と Draft 解除 |

## 対象範囲

| パス | 内容 |
| --- | --- |
| `plugins/ndf-shared/skills/cross-refactoring/scripts/` | `refactor.py` / `launch-cli.sh` / `prepare-worktrees.sh` |
| `plugins/ndf-shared/skills/cross-refactoring/tests/` | 現状固定テスト |
| `plugins/ndf-shared/skills/cross-review/scripts/lib/` | 収束ループの共通層 |
| `plugins/ndf-shared/skills/cross-review/tests/` | 現状固定テスト |

## 実行条件

| 項目 | 値 |
| --- | --- |
| ホスト | Claude Code(提案・レビューには不参加) |
| 提案・レビュー | codex / gemini / kiro |
| 適用の母集合 | claude / codex / kiro |
| 使用する版 | プラグインキャッシュの v8.5.4 |
| kiro のモデル | `claude-sonnet-5`(既定の `auto` は集計から分離されるため指定する) |
| ラウンド上限 | 3 |
| 着手前のテスト | 500 passed |

```bash
/ndf:cross-refactoring <PR番号> \
--scope plugins/ndf-shared/skills/cross-refactoring/scripts \
plugins/ndf-shared/skills/cross-refactoring/tests \
plugins/ndf-shared/skills/cross-review/scripts/lib \
plugins/ndf-shared/skills/cross-review/tests \
--model kiro=claude-sonnet-5 \
--sync-command "bash scripts/build-runtime-plugins.sh" \
--baseline-test "uv run --with pytest python -m pytest \
plugins/ndf-shared/skills/cross-refactoring/tests \
plugins/ndf-shared/skills/cross-review/tests -q" \
--max-outer-rounds 3
```

## 注意

`plugins/ndf-shared/` は編集元であり、`scripts/build-runtime-plugins.sh` で
`ndf-claude` / `ndf-codex` / `ndf-kiro` へ同期する。同期は進行側の責務のため
`--sync-command` で渡す。
Loading
Loading