Skip to content

GPU requirement and auto-detect NVIDIA extensions - #173

Merged
Christof Marti (chrmarti) merged 9 commits into
devcontainers:mainfrom
chris-major-improbable:chrism/gpu-requriements
Nov 11, 2022
Merged

GPU requirement and auto-detect NVIDIA extensions#173
Christof Marti (chrmarti) merged 9 commits into
devcontainers:mainfrom
chris-major-improbable:chrism/gpu-requriements

Conversation

@chris-major-improbable

@chris-major-improbableChris Major (chris-major-improbable) commented Sep 13, 2022•
edited
Loading

Copy link
Copy Markdown
Contributor

This PR builds upon the proposal in devcontainers/spec#82
When launching a devcontainer requesting GPUs it also detects the presence of NVIDIA docker extensions, and adds the --gpus all flag.

This means that the same devcontainer can be used by developments that don't all have GPU's.

It also does the equivalent for docker-compose scripts, adding the GPU access to the service specified in the devcontainer.json file

chrmarti
Christof Marti (chrmarti) requested changes Sep 13, 2022
View reviewed changes

@chrmartiChristof Marti (chrmarti) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! I have left a comment.

Comment threadsrc/spec-node/singleContainer.ts Outdated
@chris-major-improbable
Chris Major (chris-major-improbable)force-pushed the chrism/gpu-requriements branch 2 times, most recently from 5bf01c3 to 5af8294CompareSeptember 27, 2022 12:00
chrmarti
Christof Marti (chrmarti) reviewed Oct 3, 2022
View reviewed changes

@chrmartiChristof Marti (chrmarti) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update! I have added a few more comments.

Comment threadsrc/spec-node/dockerCompose.ts Outdated
Comment threadsrc/spec-configuration/configuration.ts Outdated
Comment threadsrc/spec-configuration/configuration.ts
chrmarti
Christof Marti (chrmarti) requested changes Oct 7, 2022
View reviewed changes

@chrmartiChristof Marti (chrmarti) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, left a few more comments. Thanks!

Comment threadsrc/spec-node/singleContainer.ts Outdated
Comment threadsrc/spec-node/imageMetadata.ts
Comment threadsrc/spec-node/dockerCompose.ts Outdated
Comment threadsrc/spec-configuration/configuration.ts Outdated
Comment threadsrc/spec-node/dockerCompose.ts Outdated
@chris-major-improbable
Chris Major (chris-major-improbable)force-pushed the chrism/gpu-requriements branch 2 times, most recently from 6dca834 to dfc50d4CompareOctober 10, 2022 16:49
chrmarti
Christof Marti (chrmarti) requested changes Oct 11, 2022
View reviewed changes

@chrmartiChristof Marti (chrmarti) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

2 more comment. :)

Comment threadsrc/spec-node/dockerCompose.ts Outdated
Comment threadsrc/spec-node/dockerCompose.ts Outdated
chrmarti
Christof Marti (chrmarti) previously approved these changes Oct 12, 2022
View reviewed changes

@chrmartiChristof Marti (chrmarti) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Looping in our partner team for cross-review. Will merge after that. Thanks!)

@chris-major-improbable

Chris Major (chris-major-improbable) commented Oct 12, 2022

Copy link
Copy Markdown
ContributorAuthor

Hey Christof Marti (@chrmarti) just seen a lot of test failures on the CI - and slightly at a loss to understand what they mean and why they are failing. I'm happy to take a look, but I'm not sure what the difference between src/test/cli.build.test.ts and src/test/cli.exec.buildKit.1.test.ts is (and how to replicated it locally?)

@chris-major-improbable

Chris Major (chris-major-improbable) commented Oct 12, 2022

Copy link
Copy Markdown
ContributorAuthor

I've taken a bit of a closer look, and rebased onto the latest main - and I see the same failures running the tests locally, so I don't think this is a regression from this PR.

@kieferrmKai Maetzel (kieferrm) mentioned this pull request Nov 6, 2022
Closed
16 tasks
@chrmarti

Christof Marti (chrmarti) commented Nov 7, 2022

Copy link
Copy Markdown
Contributor

Chris Major (@chris-major-improbable) I have merged in the main branch and fixed an issue with the PR I found when looking into the test failures. Please check the above comment from the CLA bot, we must have added that after you submitted the PR. Thanks!

@chris-major-improbable

Chris Major (chris-major-improbable) commented Nov 8, 2022

Copy link
Copy Markdown
ContributorAuthor

@microsoft-github-policy-service agree [company="{Improbable Worlds Ltd}"]

@chris-major-improbable

Chris Major (chris-major-improbable) commented Nov 8, 2022

Copy link
Copy Markdown
ContributorAuthor

@microsoft-github-policy-service agree company="{Improbable Worlds Ltd}"

@chris-major-improbable

Chris Major (chris-major-improbable) commented Nov 8, 2022

Copy link
Copy Markdown
ContributorAuthor

@microsoft-github-policy-service agree company="Improbable Worlds Ltd"

@chris-major-improbable

Chris Major (chris-major-improbable) commented Nov 8, 2022

Copy link
Copy Markdown
ContributorAuthor

Thanks for that - looks good to me.
I've merged in the latest and fixed one conflict, and should be good now.

@tbenthompsonBen Thompson (tbenthompson) mentioned this pull request Nov 9, 2022
Closed
chrmarti
Christof Marti (chrmarti) approved these changes Nov 10, 2022
View reviewed changes

@chrmartiChristof Marti (chrmarti) left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (Will get a second review now.) Thanks!

joshspicer
joshspicer approved these changes Nov 10, 2022
View reviewed changes

@joshspicerjoshspicer left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution.

samruddhikhandale
Samruddhi Khandale (samruddhikhandale) approved these changes Nov 10, 2022
View reviewed changes

@samruddhikhandaleSamruddhi Khandale (samruddhikhandale) left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks for the contribution! ✨

@chrmarti
Christof Marti (chrmarti) merged commit f533ca1 into devcontainers:mainNov 11, 2022
@jonnyyujonnyyu mentioned this pull request Dec 8, 2022
Open
@gakugakuMiyar (gakugaku) mentioned this pull request Apr 28, 2025
Open
Sign up for freeto join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chrmartiChristof Marti (chrmarti)chrmarti approved these changes
@joshspicerjoshspicerjoshspicer approved these changes
@samruddhikhandaleSamruddhi Khandale (samruddhikhandale)samruddhikhandale approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@chris-major-improbable@chrmarti@joshspicer@samruddhikhandale